DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Reverts "[Impeller] pass const ref to binding helpers." (flutter/engine#48330)

Browse Source 
Reverts flutter/engine#48318
Initiated by: jonahwilliams
This change reverts the following previous change:
Original Description:
No point in passing by value and moving, just pass a const ref through. Trivial performance improvement.

# Before
```cpp
  /// Bind uniform buffer for resource named FragInfo.
  static bool BindFragInfo(ResourceBinder& command, BufferView view) {
    return command.BindResource(ShaderStage::kFragment, kResourceFragInfo, kMetadataFragInfo, std::move(view));
  }

  /// Bind combined image sampler for resource named texture_sampler.
  static bool BindTextureSampler(ResourceBinder& command, std::shared_ptr<const Texture> texture, std::shared_ptr<const Sampler> sampler) {
    return command.BindResource(ShaderStage::kFragment, kResourceTextureSampler, kMetadataTextureSampler, std::move(texture), std::move(sampler));
  }
  ```

# After
```cpp
  /// Bind uniform buffer for resource named FragInfo.
  static bool BindFragInfo(ResourceBinder& command, const BufferView& view) {
    return command.BindResource(ShaderStage::kFragment, kResourceFragInfo, kMetadataFragInfo, view);
  }

  /// Bind combined image sampler for resource named texture_sampler.
  static bool BindTextureSampler(ResourceBinder& command, const std::shared_ptr<const Texture>& texture, const std::shared_ptr<const Sampler>& sampler) {
    return command.BindResource(ShaderStage::kFragment, kResourceTextureSampler, kMetadataTextureSampler, texture, sampler);
  }
  ```
This commit is contained in:
auto-submit[bot] 2023-11-22 20:09:17 +00:00 committed by GitHub
parent 7aba08366e
commit 4f2aeb7e76
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
engine/src/flutter/impeller/compiler/code_gen_template.h
View File

@ -163,7 +163,7 @@ struct {{camel_case(shader_name)}}{{camel_case(shader_stage)}}Shader {
return {{ proto.args.0.argument_name }}.BindResource({% for arg in proto.args %}
{% if loop.is_first %}
{{to_shader_stage(shader_stage)}}, kResource{{ proto.name }}, kMetadata{{ proto.name }}, {% else %}
{{ arg.argument_name }}{% if not loop.is_last %}, {% endif %}
std::move({{ arg.argument_name }}){% if not loop.is_last %}, {% endif %}
{% endif %}
{% endfor %});
}

12
engine/src/flutter/impeller/compiler/reflector.cc
View File

@ -1137,7 +1137,7 @@ std::vector<Reflector::BindPrototype> Reflector::ReflectBindPrototypes(
.argument_name = "command",
});
proto.args.push_back(BindPrototypeArgument{
.type_name = "const BufferView&",
.type_name = "BufferView",
.argument_name = "view",
});
}
@ -1156,7 +1156,7 @@ std::vector<Reflector::BindPrototype> Reflector::ReflectBindPrototypes(
.argument_name = "command",
});
proto.args.push_back(BindPrototypeArgument{
.type_name = "const BufferView&",
.type_name = "BufferView",
.argument_name = "view",
});
}
@ -1175,11 +1175,11 @@ std::vector<Reflector::BindPrototype> Reflector::ReflectBindPrototypes(
.argument_name = "command",
});
proto.args.push_back(BindPrototypeArgument{
.type_name = "const std::shared_ptr<const Texture>&",
.type_name = "std::shared_ptr<const Texture>",
.argument_name = "texture",
});
proto.args.push_back(BindPrototypeArgument{
.type_name = "const std::shared_ptr<const Sampler>&",
.type_name = "std::shared_ptr<const Sampler>",
.argument_name = "sampler",
});
}
@ -1198,7 +1198,7 @@ std::vector<Reflector::BindPrototype> Reflector::ReflectBindPrototypes(
.argument_name = "command",
});
proto.args.push_back(BindPrototypeArgument{
.type_name = "const std::shared_ptr<const Texture>&",
.type_name = "std::shared_ptr<const Texture>",
.argument_name = "texture",
});
}
@ -1217,7 +1217,7 @@ std::vector<Reflector::BindPrototype> Reflector::ReflectBindPrototypes(
.argument_name = "command",
});
proto.args.push_back(BindPrototypeArgument{
.type_name = "const std::shared_ptr<const Sampler>&",
.type_name = "std::shared_ptr<const Sampler>",
.argument_name = "sampler",
});
}