From 4e5093707f8c2a2da5e2f480d1ff74c2ffbc8d4c Mon Sep 17 00:00:00 2001 From: Chinmay Garde Date: Tue, 21 May 2024 12:35:46 -0700 Subject: [PATCH] Remove --trace-gn from ./flutter/tools/gn (flutter/engine#52964) This flag as originally introduced to see if it made the GN step slower. It did not do so in any measurable manner and the default was flipped to true. AFAICT, no one disables and its good to have tracelogs to debug GN slowdowns. Remove the flag. --- engine/src/flutter/tools/gn | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/engine/src/flutter/tools/gn b/engine/src/flutter/tools/gn index 70d2ff4a690..37cc2480076 100755 --- a/engine/src/flutter/tools/gn +++ b/engine/src/flutter/tools/gn @@ -1195,14 +1195,6 @@ def parse_args(args): help='Whether the -fstack-protector flag should be passed unconditionally.' ) - parser.add_argument( - '--trace-gn', - default=True, - action='store_true', - help='Write a GN trace log (gn_trace.json) in the Chromium tracing ' - 'format in the build directory.' - ) - parser.add_argument( '--darwin-extension-safe', default=False, @@ -1287,9 +1279,7 @@ def main(argv): out_dir = get_out_dir(args) command.append(out_dir) command.append('--args=%s' % ' '.join(gn_args)) - - if args.trace_gn: - command.append('--tracelog=%s/gn_trace.json' % out_dir) + command.append('--tracelog=%s/gn_trace.json' % out_dir) if args.verbose: command.append('-v')