From 4868acea586c4ac812da49f26e3fd8ccff30511f Mon Sep 17 00:00:00 2001 From: Jonah Williams Date: Fri, 19 Apr 2024 09:31:07 -0700 Subject: [PATCH] [Impeller] remove absorb opacity limit. (flutter/engine#52160) Both contents correctly check for absorb opacity so I think this is pointless. --- .../entity/contents/filters/blend_filter_contents.cc | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/engine/src/flutter/impeller/entity/contents/filters/blend_filter_contents.cc b/engine/src/flutter/impeller/entity/contents/filters/blend_filter_contents.cc index c17da0c66d0..93550da403e 100644 --- a/engine/src/flutter/impeller/entity/contents/filters/blend_filter_contents.cc +++ b/engine/src/flutter/impeller/entity/contents/filters/blend_filter_contents.cc @@ -728,8 +728,7 @@ std::optional BlendFilterContents::RenderFilter( } if (blend_mode_ <= Entity::kLastPipelineBlendMode) { - if (inputs.size() == 1 && foreground_color_.has_value() && - GetAbsorbOpacity() == ColorFilterContents::AbsorbOpacity::kYes) { + if (inputs.size() == 1 && foreground_color_.has_value()) { return CreateForegroundPorterDuffBlend( inputs[0], renderer, entity, coverage, foreground_color_.value(), blend_mode_, GetAlpha(), GetAbsorbOpacity()); @@ -739,8 +738,7 @@ std::optional BlendFilterContents::RenderFilter( } if (blend_mode_ <= Entity::kLastAdvancedBlendMode) { - if (inputs.size() == 1 && foreground_color_.has_value() && - GetAbsorbOpacity() == ColorFilterContents::AbsorbOpacity::kYes) { + if (inputs.size() == 1 && foreground_color_.has_value()) { return CreateForegroundAdvancedBlend( inputs[0], renderer, entity, coverage, foreground_color_.value(), blend_mode_, GetAlpha(), GetAbsorbOpacity());