From 47f4a2aad47de15357ae7d0bb6637e54ebe025aa Mon Sep 17 00:00:00 2001 From: Michael Goderbauer Date: Wed, 23 May 2018 16:05:15 -0700 Subject: [PATCH] Remove assert for unsupported SemanticsEvents (#5349) Not all platforms are expected to handle all SemanticsEvents. Therefore, it is ok to just drop unsupported events on the floor. --- shell/platform/android/io/flutter/view/AccessibilityBridge.java | 2 -- .../darwin/ios/framework/Source/accessibility_bridge.mm | 2 -- 2 files changed, 4 deletions(-) diff --git a/shell/platform/android/io/flutter/view/AccessibilityBridge.java b/shell/platform/android/io/flutter/view/AccessibilityBridge.java index a969b1bb6b4..ebf19111b6c 100644 --- a/shell/platform/android/io/flutter/view/AccessibilityBridge.java +++ b/shell/platform/android/io/flutter/view/AccessibilityBridge.java @@ -691,8 +691,6 @@ class AccessibilityBridge extends AccessibilityNodeProvider implements BasicMess e.getText().add((String) data.get("message")); sendAccessibilityEvent(e); } - default: - assert false; } } diff --git a/shell/platform/darwin/ios/framework/Source/accessibility_bridge.mm b/shell/platform/darwin/ios/framework/Source/accessibility_bridge.mm index 4a6d70655ed..dcfbf7dcfeb 100644 --- a/shell/platform/darwin/ios/framework/Source/accessibility_bridge.mm +++ b/shell/platform/darwin/ios/framework/Source/accessibility_bridge.mm @@ -614,8 +614,6 @@ void AccessibilityBridge::HandleEvent(NSDictionary* annotatedEven if ([type isEqualToString:@"announce"]) { NSString* message = annotatedEvent[@"data"][@"message"]; UIAccessibilityPostNotification(UIAccessibilityAnnouncementNotification, message); - } else { - NSCAssert(NO, @"Invalid event type %@", type); } }