From 463ebf640fc513d728dc193cbdd814b0ddf36c6b Mon Sep 17 00:00:00 2001 From: Konstantin Scheglov Date: Wed, 15 Sep 2021 09:22:24 -0600 Subject: [PATCH] Fix UNNECESSARY_TYPE_CHECK_TRUE (flutter/engine#28611) * Fix UNNECESSARY_TYPE_CHECK_TRUE * Fix two more places. --- engine/src/flutter/lib/web_ui/test/channel_buffers_test.dart | 2 +- engine/src/flutter/shell/testing/observatory/launcher.dart | 4 +--- engine/src/flutter/testing/dart/channel_buffers_test.dart | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/engine/src/flutter/lib/web_ui/test/channel_buffers_test.dart b/engine/src/flutter/lib/web_ui/test/channel_buffers_test.dart index efede2f1f31..21ba2d94aef 100644 --- a/engine/src/flutter/lib/web_ui/test/channel_buffers_test.dart +++ b/engine/src/flutter/lib/web_ui/test/channel_buffers_test.dart @@ -23,7 +23,7 @@ void main() { ByteData _makeByteData(String str) { final Uint8List list = utf8.encode(str) as Uint8List; - final ByteBuffer buffer = list is Uint8List ? list.buffer : Uint8List.fromList(list).buffer; + final ByteBuffer buffer = list.buffer; return ByteData.view(buffer); } diff --git a/engine/src/flutter/shell/testing/observatory/launcher.dart b/engine/src/flutter/shell/testing/observatory/launcher.dart index ce1f5cbcaac..5f8b61983e6 100644 --- a/engine/src/flutter/shell/testing/observatory/launcher.dart +++ b/engine/src/flutter/shell/testing/observatory/launcher.dart @@ -49,9 +49,7 @@ class ShellLauncher { ShellLauncher(this.shellExecutablePath, this.mainDartPath, this.startPaused, List extraArgs) { - if (extraArgs is List) { - args.addAll(extraArgs); - } + args.addAll(extraArgs); args.add(mainDartPath); } diff --git a/engine/src/flutter/testing/dart/channel_buffers_test.dart b/engine/src/flutter/testing/dart/channel_buffers_test.dart index a1495d37880..e86d5f3493f 100644 --- a/engine/src/flutter/testing/dart/channel_buffers_test.dart +++ b/engine/src/flutter/testing/dart/channel_buffers_test.dart @@ -13,7 +13,7 @@ import 'package:litetest/litetest.dart'; ByteData _makeByteData(String str) { final Uint8List list = utf8.encode(str) as Uint8List; - final ByteBuffer buffer = list is Uint8List ? list.buffer : Uint8List.fromList(list).buffer; + final ByteBuffer buffer = list.buffer; return ByteData.view(buffer); }