From 4366aa7092bd7ff7023694dcd2e4dd5bcf729416 Mon Sep 17 00:00:00 2001 From: Ian Hickson Date: Thu, 31 Aug 2023 14:46:04 -0700 Subject: [PATCH] Avoid saying exactly who can give test exemptions (flutter/engine#45343) --- engine/src/flutter/.github/PULL_REQUEST_TEMPLATE.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/engine/src/flutter/.github/PULL_REQUEST_TEMPLATE.md b/engine/src/flutter/.github/PULL_REQUEST_TEMPLATE.md index cacf41257f6..c1c1d3d05f3 100644 --- a/engine/src/flutter/.github/PULL_REQUEST_TEMPLATE.md +++ b/engine/src/flutter/.github/PULL_REQUEST_TEMPLATE.md @@ -10,7 +10,7 @@ - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [ ] I listed at least one issue that this PR fixes in the description above. -- [ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests. +- [ ] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I signed the [CLA]. - [ ] All existing and new tests are passing. @@ -20,6 +20,7 @@ If you need help, consider asking for advice on the #hackers-new channel on [Dis [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene +[test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine