From 428bd7ee937be29d54829bcc81c24b60e79dfa0e Mon Sep 17 00:00:00 2001
From: Kaushik Iska <iska.kaushik@gmail.com>
Date: Mon, 17 Oct 2022 11:33:51 -0500
Subject: [PATCH] [Impeller] Do not terminate on performance related validation
 failures (flutter/engine#36776)

---
 .../impeller/renderer/backend/vulkan/context_vk.cc  | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/engine/src/flutter/impeller/renderer/backend/vulkan/context_vk.cc b/engine/src/flutter/impeller/renderer/backend/vulkan/context_vk.cc
index 3e071ebb20c..7d6850a04e7 100644
--- a/engine/src/flutter/impeller/renderer/backend/vulkan/context_vk.cc
+++ b/engine/src/flutter/impeller/renderer/backend/vulkan/context_vk.cc
@@ -347,9 +347,16 @@ ContextVK::ContextVK(
            VkDebugUtilsMessageTypeFlagsEXT type,
            const VkDebugUtilsMessengerCallbackDataEXT* data,
            void* user_data) -> VkBool32 {
-      FML_DCHECK(false)
-          << vk::to_string(vk::DebugUtilsMessageSeverityFlagBitsEXT{severity})
-          << ": " << data->pMessage;
+      if (type == VK_DEBUG_UTILS_MESSAGE_TYPE_PERFORMANCE_BIT_EXT) {
+        // do not terminate on performance warnings.
+        FML_LOG(ERROR)
+            << vk::to_string(vk::DebugUtilsMessageSeverityFlagBitsEXT{severity})
+            << ": " << data->pMessage;
+      } else {
+        FML_DCHECK(false)
+            << vk::to_string(vk::DebugUtilsMessageSeverityFlagBitsEXT{severity})
+            << ": " << data->pMessage;
+      }
       return true;
     };