From 422d8d2dade18d544b0b10dd09a73cba99a3a9bc Mon Sep 17 00:00:00 2001 From: Nicholas Shahan Date: Thu, 29 May 2025 12:00:57 -0700 Subject: [PATCH] [tests] Increase linux timeout and skip on others (#169627) With this change the web.shard test suite runs all existing tests on all platforms with the version of the web debug builds that is the flutter tools default (does not support stateful hot reload). The linux bot configuration will also run some of the tests using the new web debug build (supports stateful hot reload). The timeout has been increased for this configuration to allow the additional tests to run to completion. The mac and windows configurations skip all tests for the new web debug builds. In the future the new build output will become the flutter tools default and the balance of where the tests tests are run will flip until the ability to opt out of the new build output is removed. This change is not ideal because we are still not fully testing all features with the two versions of the web debug builds that are available to users. If given the opportunity we should add additional bot configurations to run all the tests with the output that supports stateful hot reload. Fixes: https://github.com/flutter/flutter/issues/169304 Issue: https://github.com/flutter/flutter/issues/169634 --- .ci.yaml | 4 ++-- .../test/web.shard/expression_evaluation_web_amd_test.dart | 1 - .../expression_evaluation_web_ddc_library_bundle_test.dart | 2 +- .../test/web.shard/hot_reload_web_errors_test.dart | 1 + .../flutter_tools/test/web.shard/hot_reload_web_test.dart | 1 + .../test/web.shard/hot_reload_with_asset_web_test.dart | 1 + .../web.shard/hot_restart_web_ddc_library_bundle_test.dart | 1 + .../web.shard/stateless_stateful_hot_reload_web_test.dart | 1 + 8 files changed, 8 insertions(+), 4 deletions(-) diff --git a/.ci.yaml b/.ci.yaml index f6a85130f01..f4aedb4e118 100644 --- a/.ci.yaml +++ b/.ci.yaml @@ -2246,7 +2246,7 @@ targets: - name: Linux web_tool_tests recipe: flutter/flutter_drone - timeout: 60 + timeout: 90 # https://github.com/flutter/flutter/issues/169634 properties: dependencies: >- [ @@ -2261,7 +2261,7 @@ targets: ["framework", "hostonly", "shard", "linux"] # Retry for flakes caused by https://github.com/flutter/flutter/issues/132654 presubmit_max_attempts: "2" - test_timeout_secs: "3600" # https://github.com/flutter/flutter/issues/162714 + test_timeout_secs: "5400" # https://github.com/flutter/flutter/issues/162714 runIf: - dev/** - packages/flutter_tools/** diff --git a/packages/flutter_tools/test/web.shard/expression_evaluation_web_amd_test.dart b/packages/flutter_tools/test/web.shard/expression_evaluation_web_amd_test.dart index 0a8db50894b..6e72fb1da42 100644 --- a/packages/flutter_tools/test/web.shard/expression_evaluation_web_amd_test.dart +++ b/packages/flutter_tools/test/web.shard/expression_evaluation_web_amd_test.dart @@ -3,7 +3,6 @@ // found in the LICENSE file. @Tags(['flutter-test-driver']) -@Skip('https://github.com/flutter/flutter/issues/169304') library; import '../src/common.dart'; diff --git a/packages/flutter_tools/test/web.shard/expression_evaluation_web_ddc_library_bundle_test.dart b/packages/flutter_tools/test/web.shard/expression_evaluation_web_ddc_library_bundle_test.dart index 7064367ee05..f95ddc338ec 100644 --- a/packages/flutter_tools/test/web.shard/expression_evaluation_web_ddc_library_bundle_test.dart +++ b/packages/flutter_tools/test/web.shard/expression_evaluation_web_ddc_library_bundle_test.dart @@ -2,8 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +@TestOn('linux') // https://github.com/flutter/flutter/issues/169304 @Tags(['flutter-test-driver']) -@Skip('https://github.com/flutter/flutter/issues/169304') library; import '../src/common.dart'; diff --git a/packages/flutter_tools/test/web.shard/hot_reload_web_errors_test.dart b/packages/flutter_tools/test/web.shard/hot_reload_web_errors_test.dart index 9c35bb76157..de811a8457b 100644 --- a/packages/flutter_tools/test/web.shard/hot_reload_web_errors_test.dart +++ b/packages/flutter_tools/test/web.shard/hot_reload_web_errors_test.dart @@ -2,6 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +@TestOn('linux') // https://github.com/flutter/flutter/issues/169304 @Tags(['flutter-test-driver']) library; diff --git a/packages/flutter_tools/test/web.shard/hot_reload_web_test.dart b/packages/flutter_tools/test/web.shard/hot_reload_web_test.dart index a388b3afd24..5763757c3d3 100644 --- a/packages/flutter_tools/test/web.shard/hot_reload_web_test.dart +++ b/packages/flutter_tools/test/web.shard/hot_reload_web_test.dart @@ -2,6 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +@TestOn('linux') // https://github.com/flutter/flutter/issues/169304 @Tags(['flutter-test-driver']) library; diff --git a/packages/flutter_tools/test/web.shard/hot_reload_with_asset_web_test.dart b/packages/flutter_tools/test/web.shard/hot_reload_with_asset_web_test.dart index 45551c06a08..6621653ac68 100644 --- a/packages/flutter_tools/test/web.shard/hot_reload_with_asset_web_test.dart +++ b/packages/flutter_tools/test/web.shard/hot_reload_with_asset_web_test.dart @@ -2,6 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +@TestOn('linux') // https://github.com/flutter/flutter/issues/169304 @Tags(['flutter-test-driver']) library; diff --git a/packages/flutter_tools/test/web.shard/hot_restart_web_ddc_library_bundle_test.dart b/packages/flutter_tools/test/web.shard/hot_restart_web_ddc_library_bundle_test.dart index 542e728e3b7..ccb808f225a 100644 --- a/packages/flutter_tools/test/web.shard/hot_restart_web_ddc_library_bundle_test.dart +++ b/packages/flutter_tools/test/web.shard/hot_restart_web_ddc_library_bundle_test.dart @@ -2,6 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +@TestOn('linux') // https://github.com/flutter/flutter/issues/169304 @Tags(['flutter-test-driver']) library; diff --git a/packages/flutter_tools/test/web.shard/stateless_stateful_hot_reload_web_test.dart b/packages/flutter_tools/test/web.shard/stateless_stateful_hot_reload_web_test.dart index 6b0ab1447bb..4f1440423b1 100644 --- a/packages/flutter_tools/test/web.shard/stateless_stateful_hot_reload_web_test.dart +++ b/packages/flutter_tools/test/web.shard/stateless_stateful_hot_reload_web_test.dart @@ -2,6 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +@TestOn('linux') // https://github.com/flutter/flutter/issues/169304 @Tags(['flutter-test-driver']) library;