Download material design icons using DEPS

We need the material design icons at build time in order to build Sky
application bundles that include the icons. Therefore, we need can't wait until
runtime to download the icons.

Also, rather than copying all the icons into each out directory, we just
symlink to the copy in the source tree.

R=eseidel@chromium.org, eseidel@google.com

Review URL: https://codereview.chromium.org/1217283002.
This commit is contained in:
Adam Barth 2015-06-30 10:32:09 -07:00
parent 7be6bf978d
commit 41ffb31681

View File

@ -126,18 +126,6 @@ def dev_packages_root(build_dir):
return os.path.join(build_dir, 'gen', 'dart-pkg', 'packages')
def ensure_assets_are_downloaded(build_dir):
sky_pkg_dir = os.path.join(build_dir, 'gen', 'dart-pkg', 'sky')
sky_pkg_lib_dir = os.path.join(sky_pkg_dir, 'lib')
sky_icons_dir = \
os.path.join(sky_pkg_lib_dir, 'assets', 'material-design-icons')
if not os.path.isdir(sky_icons_dir):
logging.info('NOTE: sky/assets/material-design-icons missing, '
'Running `download_material_design_icons` for you.')
subprocess.check_call(
[os.path.join(sky_pkg_lib_dir, 'download_material_design_icons')])
class SetBuildDir(object):
def add_subparser(self, subparsers):
start_parser = subparsers.add_parser('set_build_dir',
@ -198,8 +186,6 @@ class StartSky(object):
print "'%s' does not exist?" % apk_path
return 2
ensure_assets_are_downloaded(args.build_dir)
packages_root = dev_packages_root(args.build_dir)
sky_server = self._sky_server_for_args(args, packages_root)
pids['sky_server_pid'] = sky_server.start()