From 406891841fc287c942705d6b30a98a7bea43fb5f Mon Sep 17 00:00:00 2001
From: Siva <a-siva@users.noreply.github.com>
Date: Wed, 29 Jul 2020 20:52:06 -0700
Subject: [PATCH] Manual roll of Dart 40fd1c456e...7e8348f4ce (#20125)

* Manual roll of Dart 40fd1c456e...7e8348f4ce

dart-lang/sdk@7e8348f4ce [dart2js] Assume `isPotentialSubtype` is always true.
dart-lang/sdk@5671730c5a [dart2js] Pass type arguments to callable properties even with --omit-implicit-checks.
dart-lang/sdk@4c74ebb367 [benchmark] Add dartdevc-null targets.
dart-lang/sdk@56708696a9 [vm/nnbd/bytecode] Distinguish function types with different nullabilities in bytecode generator
dart-lang/sdk@d2f7039e9c [dart:io] Parse scoped IPv6 in constructor of InternetAddress
dart-lang/sdk@c2d28d1569 Rename Null Safety tests.
dart-lang/sdk@4d3ec06277 Add more data and performance operations for Cider.
dart-lang/sdk@3103d859e4 Remove unused TypeSystemImpl.mostSpecificTypeArgument().
dart-lang/sdk@6d9a4f16dd Issue 42757. Implement null spread element typing with null-safety.
dart-lang/sdk@8c316a99de Remove unnecessary null checks.
dart-lang/sdk@6c9b885e57 Remove StrongModeCode.INVALID_PARAMETER_DECLARATION; it's redundant
dart-lang/sdk@b98eb386ea [ddc] Use prebuilt_dart_action to build js
dart-lang/sdk@8796382840 Analyzer: Move invalid_super_invocation to compile-time error
dart-lang/sdk@cece303eb4 Check diagnostics in List/Map/SetLiteralTest(s).
dart-lang/sdk@cc519b9a03 Test that during partial resolution for Cider we don't resolve some nodes.
dart-lang/sdk@4ea6d6e130 [tests/ffi] Re-enable commented out tests
dart-lang/sdk@2225b6f472 Migration: fix handling of async functions that return FutureOr.
dart-lang/sdk@f907e561c9 Migration: never produce a type of the form `FutureOr<T?>?`.
dart-lang/sdk@69ba6e5f80 Make FileSystemEntity.absolutePath understand more Windows paths.
dart-lang/sdk@202e32afeb [vm] Native API: Introduce Dart_FinalizableHandle
dart-lang/sdk@debb4dddea [co19] Language/Types and Language/Variables tests enabled
dart-lang/sdk@3661464297 [infra] Update checked-in SDKs to 2.10.0-0.0.dev
dart-lang/sdk@b8dc7627a9 [cfe] Handle NullCheck in constant evaluation

* Switch Android windows builds to also use clang.

* Bump buildroot version to fe3b46e595e7ce1350e11aa0c90365976051f4a3

* Update license.
---
 DEPS                                    | 6 +++---
 ci/licenses_golden/licenses_third_party | 2 +-
 tools/gn                                | 5 +----
 3 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/DEPS b/DEPS
index 0995eb648c5..12f11542f66 100644
--- a/DEPS
+++ b/DEPS
@@ -34,7 +34,7 @@ vars = {
   # Dart is: https://github.com/dart-lang/sdk/blob/master/DEPS.
   # You can use //tools/dart/create_updated_flutter_deps.py to produce
   # updated revision list of existing dependencies.
-  'dart_revision': '40fd1c456e0a872ab8f6d2a018b3436d2f7a5f84',
+  'dart_revision': '7e8348f4ce87f89235154e974c799de57473c4f4',
 
   # WARNING: DO NOT EDIT MANUALLY
   # The lines between blank lines above and below are generated by a script. See create_updated_flutter_deps.py
@@ -107,7 +107,7 @@ allowed_hosts = [
 ]
 
 deps = {
-  'src': 'https://github.com/flutter/buildroot.git' + '@' + '92f0936b9c4daec1af9296125d449807bdec9219',
+  'src': 'https://github.com/flutter/buildroot.git' + '@' + 'fe3b46e595e7ce1350e11aa0c90365976051f4a3',
 
    # Fuchsia compatibility
    #
@@ -354,7 +354,7 @@ deps = {
    Var('dart_git') + '/package_config.git@9c586d04bd26fef01215fd10e7ab96a3050cfa64',
 
   'src/third_party/dart/tools/sdks':
-   {'packages': [{'version': 'version:2.10.0-0.2-preview', 'package': 'dart/dart-sdk/${{platform}}'}], 'dep_type': 'cipd'},
+   {'packages': [{'version': 'version:2.10.0-0.0.dev', 'package': 'dart/dart-sdk/${{platform}}'}], 'dep_type': 'cipd'},
 
   # WARNING: end of dart dependencies list that is cleaned up automatically - see create_updated_flutter_deps.py.
 
diff --git a/ci/licenses_golden/licenses_third_party b/ci/licenses_golden/licenses_third_party
index 62e72bff8d7..7183989ca56 100644
--- a/ci/licenses_golden/licenses_third_party
+++ b/ci/licenses_golden/licenses_third_party
@@ -1,4 +1,4 @@
-Signature: dd3f14467338211a5281510f79cfd417
+Signature: ab340e8a5209fd5df1280660cafa4ccd
 
 UNUSED LICENSES:
 
diff --git a/tools/gn b/tools/gn
index b906d41cc56..6ec42f64e93 100755
--- a/tools/gn
+++ b/tools/gn
@@ -99,10 +99,7 @@ def to_gn_args(args):
     gn_args['is_debug'] = args.unoptimized
     gn_args['android_full_debug'] = args.target_os == 'android' and args.unoptimized
     if args.clang is None:
-      # Android gen_snapshot currently isn't buildable with clang on Windows.
-      # For everything else, default to clang.
-      gn_args['is_clang'] = not (sys.platform.startswith(('cygwin', 'win')) and
-                                 args.target_os == 'android')
+      gn_args['is_clang'] = True
     else:
       gn_args['is_clang'] = args.clang