DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Do not pass short-lived buffers as labels to Dart_TimelineEvent (#8166)

Browse Source 
Dart no longer makes a copy of the label string when recording events.

See https://github.com/flutter/engine/pull/8152
This commit is contained in:
Jason Simmons 2019-03-14 12:49:42 -07:00 committed by GitHub
parent e514f0bd18
commit 403337ebb8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
fml/trace_event.h
View File

@ -205,12 +205,12 @@ void TraceEventFlowEnd0(TraceArg category_group, TraceArg name, TraceIDArg id);
class ScopedInstantEnd {
public:
ScopedInstantEnd(std::string str) : label_(std::move(str)) {}
ScopedInstantEnd(const char* str) : label_(str) {}
~ScopedInstantEnd() { TraceEventEnd(label_.c_str()); }
~ScopedInstantEnd() { TraceEventEnd(label_); }
private:
const std::string label_;
const char* label_;
FML_DISALLOW_COPY_AND_ASSIGN(ScopedInstantEnd);
};