Add presubmit check for engine to flutter roll (#5790)

This prevents us from getting flutter far behind engine in the future.
The additional travis check will also stop the skia autoroller even
if we foget to turn it off.
This commit is contained in:
liyuqian 2018-07-18 11:08:25 -07:00 committed by GitHub
parent 5557e3006e
commit 3fe63fd5d9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 22 additions and 0 deletions

View File

@ -5,6 +5,7 @@ sudo: false
before_script:
- ./travis/setup.sh
script:
- ./travis/check_roll.sh
- ./travis/format.sh
- ./travis/build.sh
- ./travis/test.sh

21
travis/check_roll.sh Executable file
View File

@ -0,0 +1,21 @@
#!/bin/bash
if git remote get-url upstream >/dev/null 2>&1; then
UPSTREAM=upstream/master
else
UPSTREAM=master
fi;
FLUTTER_VERSION="$(curl -s https://raw.githubusercontent.com/flutter/flutter/master/bin/internal/engine.version)"
BEHIND="$(git rev-list $FLUTTER_VERSION..$UPSTREAM --oneline | wc -l)"
MAX_BEHIND=16 # no more than 4 bisections to identify the issue
if [[ $BEHIND -le $MAX_BEHIND ]]; then
echo "OK, the flutter/engine to flutter/flutter roll is only $BEHIND commits behind."
else
echo "ERROR: The flutter/engine to flutter/flutter roll is $BEHIND commits behind!"
echo " It exceeds our max allowance of $MAX_BEHIND. Unless that this commit fixes the roll,"
echo " please roll engine into flutter first before merging more commits into engine."
exit 1
fi