From 3e4dabb16d51a850de5d0e82c1e372a494065bd2 Mon Sep 17 00:00:00 2001 From: Jesse Seales <103135467+sealesj@users.noreply.github.com> Date: Tue, 23 May 2023 15:08:54 -0400 Subject: [PATCH] Revert "Vuln scan on 3p deps triggered by label on PR" (flutter/engine#42256) Reverts flutter/engine#42247 Reverting in order to find solution which doesn't add a skipped test onto all PRs. Only PRs which address vuln scanning need to have this test showing at all. --- engine/src/flutter/.github/workflows/third_party_scan.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/engine/src/flutter/.github/workflows/third_party_scan.yml b/engine/src/flutter/.github/workflows/third_party_scan.yml index 64b064e1b4f..8d0657a5b50 100644 --- a/engine/src/flutter/.github/workflows/third_party_scan.yml +++ b/engine/src/flutter/.github/workflows/third_party_scan.yml @@ -4,8 +4,6 @@ on: branch_protection_rule: push: branches: [ main ] - pull_request: - types: [ labeled ] # Declare default permissions as read only. permissions: read-all @@ -14,9 +12,7 @@ jobs: vuln-scan: name: Vulnerability scanning runs-on: ubuntu-20.04 - # run on flutter/engine push to main or PRs with 'vulnerability patch' label - if: ${{ github.repository == 'flutter/engine' && (github.event_name == 'push' || github.event.label.name == 'vulnerability patch') }} - + if: ${{ github.repository == 'flutter/engine' }} permissions: # Needed to upload the SARIF results to code-scanning dashboard. security-events: write