From 3cc25bb2558d38ddecdaf043b9b4ea051d1fa22a Mon Sep 17 00:00:00 2001 From: Hixie Date: Mon, 17 Aug 2015 16:57:08 -0700 Subject: [PATCH] Fix analyzer to not change the working directory. I didn't understand what was going on before. Now I do. This is a better fix that making the path absolute. --- sky/tools/skyanalyzer | 4 ++-- travis/build.sh | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sky/tools/skyanalyzer b/sky/tools/skyanalyzer index ce09da5464e..366e4421dfb 100755 --- a/sky/tools/skyanalyzer +++ b/sky/tools/skyanalyzer @@ -49,10 +49,10 @@ def main(): try: subprocess.check_output([ - DARTANALYZER, "--package-warnings", os.path.abspath(args.app_path), + DARTANALYZER, "--package-warnings", args.app_path, "--package-root", os.path.join(WORKBENCH, "packages"), "--fatal-warnings" - ], stderr=subprocess.STDOUT, cwd=WORKBENCH) + ], stderr=subprocess.STDOUT) except subprocess.CalledProcessError as e: errors = [l for l in e.output.split('\n') if not any(p.match(l) for p in _IGNORED_PATTERNS)] diff --git a/travis/build.sh b/travis/build.sh index 4798d6999a0..2c26a863bab 100755 --- a/travis/build.sh +++ b/travis/build.sh @@ -3,4 +3,4 @@ set -ex ./sky/tools/gn --release ninja -j 4 -C out/Release -./sky/tools/skyanalyzer --congratulate ../../../examples/stocks/lib/main.dart +./sky/tools/skyanalyzer --congratulate examples/stocks/lib/main.dart