DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-12 05:42:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix addAllowedPointer() overrides (#82834)

Browse Source 
They should have been taking a PointerDownEvent.

This change was originally included in #81884, but that
had to be reverted because it broke Google testss. This
sub-part of that larger change needs to be made first in
order to allow for a phased rollout in a way that won't
break Google tests.

https://github.com/flutter/flutter/issues/81883
This commit is contained in:
Todd Volkert 2021-05-18 20:28:06 -07:00 committed by GitHub
parent f512ebfd06
commit 3b19dfd4da
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter/lib/src/gestures/force_press.dart
View File

@ -216,7 +216,7 @@ class ForcePressGestureRecognizer extends OneSequenceGestureRecognizer {
_ForceState _state = _ForceState.ready;
@override
void addAllowedPointer(PointerEvent event) {
void addAllowedPointer(PointerDownEvent event) {
// If the device has a maximum pressure of less than or equal to 1, it
// doesn't have touch pressure sensing capabilities. Do not participate
// in the gesture arena.

2
packages/flutter/lib/src/gestures/monodrag.dart
View File

@ -262,7 +262,7 @@ abstract class DragGestureRecognizer extends OneSequenceGestureRecognizer {
}
@override
void addAllowedPointer(PointerEvent event) {
void addAllowedPointer(PointerDownEvent event) {
startTrackingPointer(event.pointer, event.transform);
_velocityTrackers[event.pointer] = velocityTrackerBuilder(event);
if (_state == _DragState.ready) {

2
packages/flutter/lib/src/gestures/multitap.dart
View File

@ -507,7 +507,7 @@ class MultiTapGestureRecognizer extends GestureRecognizer {
final Map<int, _TapGesture> _gestureMap = <int, _TapGesture>{};
@override
void addAllowedPointer(PointerEvent event) {
void addAllowedPointer(PointerDownEvent event) {
assert(!_gestureMap.containsKey(event.pointer));
_gestureMap[event.pointer] = _TapGesture(
gestureRecognizer: this,

2
packages/flutter/lib/src/gestures/scale.dart
View File

@ -350,7 +350,7 @@ class ScaleGestureRecognizer extends OneSequenceGestureRecognizer {
}
@override
void addAllowedPointer(PointerEvent event) {
void addAllowedPointer(PointerDownEvent event) {
startTrackingPointer(event.pointer, event.transform);
_velocityTrackers[event.pointer] = VelocityTracker.withKind(event.kind);
if (_state == _ScaleState.ready) {