DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

[Impeller] fix comment on savelayer utils. (flutter/engine#55049)

Browse Source 
Doubled comment, remove extra words!
This commit is contained in:
Jonah Williams 2024-09-10 16:27:13 -07:00 committed by GitHub
parent 0ff9f84847
commit 3aebd0267b
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
engine/src/flutter/impeller/entity/save_layer_utils.cc
View File

@ -72,15 +72,15 @@ std::optional<Rect> ComputeSaveLayerCoverage(
}
// Trimming the content coverage by the coverage limit can reduce memory
// coverage. limit can reduce memory bandwith. But in cases where there are
// animated matrix filters, such as in the framework's zoom transition, the
// changing scale values continually change the source_coverage_limit.
// Intersecting the source_coverage_limit with the coverage may result in
// slightly different texture sizes each frame of the animation. This leads
// to non-optimal allocation patterns as differently sized textures cannot
// be reused. Hence the following herustic: If the coverage is within a
// semi-arbitrary percentage of the intersected coverage, then just use the
// transformed coverage. In other cases, use the intersection.
// bandwith. But in cases where there are animated matrix filters, such as
// in the framework's zoom transition, the changing scale values continually
// change the source_coverage_limit. Intersecting the source_coverage_limit
// with the coverage may result in slightly different texture sizes each
// frame of the animation. This leads to non-optimal allocation patterns as
// differently sized textures cannot be reused. Hence the following
// herustic: If the coverage is within a semi-arbitrary percentage of the
// intersected coverage, then just use the transformed coverage. In other
// cases, use the intersection.
auto transformed_coverage = coverage.TransformBounds(effect_transform);
auto intersected_coverage =
transformed_coverage.Intersection(source_coverage_limit.value());