DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Avoid sending zero transform semantic nodes to the engine (#111843)

Browse Source
This commit is contained in:
Dan Field 2022-09-19 13:11:47 -07:00 committed by GitHub
parent 70b19ff987
commit 36a5a0f55f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 28 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter/lib/src/rendering/object.dart
View File

@ -4433,7 +4433,7 @@ class _SemanticsGeometry {
/// by this object can be dropped from the semantics tree without losing
/// semantics information.
bool get dropFromTree {
return _rect.isEmpty;
return _rect.isEmpty || _transform.isZero();
}
/// Whether the [SemanticsNode] annotated with the geometric information

27
packages/flutter/test/widgets/semantics_test.dart
View File

@ -1632,6 +1632,33 @@ void main() {
textDirection: TextDirection.ltr,
));
});
testWidgets('Semantics with zero transform gets dropped', (WidgetTester tester) async {
// Regression test for https://github.com/flutter/flutter/issues/110671.
// Construct a widget tree that will end up with a fitted box that applies
// a zero transform because it does not actually draw its children.
// Assert that this subtree gets dropped (the root node has no children).
await tester.pumpWidget(Column(
children: <Widget>[
SizedBox(
height: 0,
width: 500,
child: FittedBox(
child: SizedBox(
height: 55,
width: 266,
child: SingleChildScrollView(child: Column()),
),
),
),
],
));
final SemanticsNode node = RendererBinding.instance.renderView.debugSemantics!;
expect(node.transform, null); // Make sure the zero transform didn't end up on the root somehow.
expect(node.childrenCount, 0);
});
}
class CustomSortKey extends OrdinalSortKey {