From 35edbe3d9d3308b31b4c4329cae8ebe22352a6ac Mon Sep 17 00:00:00 2001 From: Jonah Williams Date: Fri, 24 Apr 2020 09:38:49 -0700 Subject: [PATCH] Revert "[flutter_tools] fix version tag `v` stripping (#55385)" (#55577) This reverts commit c91a3a74ec284c876cc34223444d7385eed241e1. --- .../lib/src/commands/version.dart | 2 +- .../commands.shard/hermetic/version_test.dart | 24 +------------------ 2 files changed, 2 insertions(+), 24 deletions(-) diff --git a/packages/flutter_tools/lib/src/commands/version.dart b/packages/flutter_tools/lib/src/commands/version.dart index 6a698c8505f..6727a469fa6 100644 --- a/packages/flutter_tools/lib/src/commands/version.dart +++ b/packages/flutter_tools/lib/src/commands/version.dart @@ -87,7 +87,7 @@ class VersionCommand extends FlutterCommand { } } - final String version = argResults.rest[0].replaceFirst(RegExp('^v'), ''); + final String version = argResults.rest[0].replaceFirst('v', ''); final List matchingTags = tags.where((String tag) => tag.contains(version)).toList(); String matchingTag; // TODO(fujino): make this a tool exit and fix tests diff --git a/packages/flutter_tools/test/commands.shard/hermetic/version_test.dart b/packages/flutter_tools/test/commands.shard/hermetic/version_test.dart index 419a64d2417..4ff197e9801 100644 --- a/packages/flutter_tools/test/commands.shard/hermetic/version_test.dart +++ b/packages/flutter_tools/test/commands.shard/hermetic/version_test.dart @@ -71,28 +71,6 @@ void main() { FlutterVersion: () => mockVersion, }); - testUsingContext('dev version switch prompt is accepted', () async { - when(mockStdio.stdinHasTerminal).thenReturn(true); - const String version = '30.0.0-dev.0.0'; - final VersionCommand command = VersionCommand(); - when(globals.terminal.promptForCharInput(['y', 'n'], - logger: anyNamed('logger'), - prompt: 'Are you sure you want to proceed?') - ).thenAnswer((Invocation invocation) async => 'y'); - - await createTestCommandRunner(command).run([ - 'version', - '--no-pub', - version, - ]); - expect(testLogger.statusText, contains('Switching Flutter to version $version')); - }, overrides: { - ProcessManager: () => MockProcessManager(), - Stdio: () => mockStdio, - AnsiTerminal: () => MockTerminal(), - FlutterVersion: () => mockVersion, - }); - testUsingContext('version switch prompt is declined', () async { when(mockStdio.stdinHasTerminal).thenReturn(true); const String version = '10.0.0'; @@ -261,7 +239,7 @@ class MockProcessManager extends Mock implements ProcessManager { return ProcessResult(0, 0, 'v10.0.0\r\nv20.0.0\r\n30.0.0-dev.0.0', ''); } if (command[0] == 'git' && command[1] == 'checkout') { - version = (command[2] as String).replaceFirst(RegExp('^v'), ''); + version = (command[2] as String).replaceFirst('v', ''); } return ProcessResult(0, 0, '', ''); }