From 35c33aeb08386fa04442b28b866b600f8e4a1465 Mon Sep 17 00:00:00 2001 From: Adam Barth Date: Thu, 18 Jun 2015 12:17:05 -0700 Subject: [PATCH] Don't crash if you call document.createText(null) Fixes #165. R=jackson@google.com, jackson@chromium.org Review URL: https://codereview.chromium.org/1196463002. --- .../tests/raw/null_text_crash-expected.txt | 6 ++++++ .../src/flutter/tests/raw/null_text_crash.dart | 17 +++++++++++++++++ 2 files changed, 23 insertions(+) create mode 100644 engine/src/flutter/tests/raw/null_text_crash-expected.txt create mode 100644 engine/src/flutter/tests/raw/null_text_crash.dart diff --git a/engine/src/flutter/tests/raw/null_text_crash-expected.txt b/engine/src/flutter/tests/raw/null_text_crash-expected.txt new file mode 100644 index 00000000000..7e9607842e3 --- /dev/null +++ b/engine/src/flutter/tests/raw/null_text_crash-expected.txt @@ -0,0 +1,6 @@ +CONSOLE: unittest-suite-wait-for-done +CONSOLE: PASS: createText(null) shouldn't crash +CONSOLE: +CONSOLE: All 1 tests passed. +CONSOLE: unittest-suite-success +DONE diff --git a/engine/src/flutter/tests/raw/null_text_crash.dart b/engine/src/flutter/tests/raw/null_text_crash.dart new file mode 100644 index 00000000000..441646ab2a8 --- /dev/null +++ b/engine/src/flutter/tests/raw/null_text_crash.dart @@ -0,0 +1,17 @@ +// Copyright 2015 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +import 'dart:sky' as sky; + +import '../resources/third_party/unittest/unittest.dart'; +import '../resources/unit.dart'; + +void main() { + initUnit(); + + test("createText(null) shouldn't crash", () { + var doc = new sky.Document(); + doc.createText(null); + }); +}