DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Catch divide-by-zero errors early in license tool (flutter/engine#4382)

Browse Source 
If Progress is instantiated with a max of 0, throw immediately to avoid
a divide-by-zero later in toString(). This typically happens if the tool
recurses over an empty top-level component, which can happen when a
component is moved around in the repo and the developer hasn't cleaned
up old empty directories from their git client.
This commit is contained in:
Chris Bracken 2017-11-21 15:42:17 -08:00 committed by GitHub
parent 2aad4c763e
commit 348fff3dd4
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
engine/src/flutter/tools/licenses/lib/main.dart
View File

@ -2313,7 +2313,13 @@ class RepositoryRoot extends RepositoryDirectory {
class Progress {
Progress(this.max);
Progress(this.max) {
// This may happen when a git client contains left-over empty component
// directories after DEPS file changes.
if (max <= 0)
throw new ArgumentError('Progress.max must be > 0 but was: $max');
}
final int max;
int get withLicense => _withLicense;
int _withLicense = 0;