DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Declare locals as final where not reassigned (#8576)

Browse Source 
Fix a few regressions.
This commit is contained in:
Chris Bracken 2017-03-03 18:40:19 -08:00 committed by GitHub
parent cdeb83cf59
commit 33ef949efc
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
examples/platform_services/lib/main.dart
View File

@ -19,7 +19,7 @@ class _PlatformServicesState extends State<PlatformServices> {
Future<Null> _getLocation() async {
String location;
try {
List<double> result = await platform.invokeMethod('getLocation', 'network');
final List<double> result = await platform.invokeMethod('getLocation', 'network');
location = 'Latitude ${result[0]}, Longitude ${result[1]}.';
} on PlatformException catch (e) {
location = "Failed to get location: '${e.message}'.";

10
packages/flutter_tools/test/devfs_test.dart
View File

@ -145,11 +145,11 @@ void main() {
expect(bytes, 69);
});
testUsingContext('add new package with double slashes in URI', () async {
String packageName = 'doubleslashpkg';
final String packageName = 'doubleslashpkg';
await _createPackage(packageName, 'somefile.txt', doubleSlash: true);
Set<String> fileFilter = new Set<String>();
List<Uri> pkgUris = <Uri>[fs.path.toUri(basePath)]..addAll(_packages.values);
final Set<String> fileFilter = new Set<String>();
final List<Uri> pkgUris = <Uri>[fs.path.toUri(basePath)]..addAll(_packages.values);
for (Uri pkgUri in pkgUris) {
if (!pkgUri.isAbsolute) {
pkgUri = fs.path.toUri(fs.path.join(basePath, pkgUri.path));
@ -161,7 +161,7 @@ void main() {
.toList());
}
int bytes = await devFS.update(fileFilter: fileFilter);
final int bytes = await devFS.update(fileFilter: fileFilter);
devFSOperations.expectMessages(<String>[
'writeFile test .packages',
'writeFile test packages/doubleslashpkg/somefile.txt',
@ -364,7 +364,7 @@ Future<Null> _createPackage(String pkgName, String pkgFileName, { bool doubleSla
String pkgFilePath = fs.path.join(pkgTempDir.path, pkgName, 'lib', pkgFileName);
if (doubleSlash) {
// Force two separators into the path.
String doubleSlash = fs.path.separator + fs.path.separator;
final String doubleSlash = fs.path.separator + fs.path.separator;
pkgFilePath = pkgTempDir.path + doubleSlash + fs.path.join(pkgName, 'lib', pkgFileName);
}
final File pkgFile = fs.file(pkgFilePath);