From 330c06a4f2bd3dbc9217517841f12bffc569fd52 Mon Sep 17 00:00:00 2001
From: Jonah Williams <jonahwilliams@google.com>
Date: Tue, 21 Nov 2023 16:24:06 -0800
Subject: [PATCH] [Impeller] Dont copy the paint until we're sure that the
 RRect blur optimization will apply. (flutter/engine#48298)

Extremely minor micro optimization. Dont copy the paint too early.

Before

![image](https://github.com/flutter/engine/assets/8975114/b5884e02-25ed-4e53-a6e0-d8d5a6a9a79a)

13/269 = ~5%

After:

![image](https://github.com/flutter/engine/assets/8975114/ac5981bb-40c6-4a38-b24c-46b7ad5399a4)

3/262 = ~1%
---
 engine/src/flutter/impeller/aiks/canvas.cc | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/engine/src/flutter/impeller/aiks/canvas.cc b/engine/src/flutter/impeller/aiks/canvas.cc
index 8cc569877ec..6d40570450c 100644
--- a/engine/src/flutter/impeller/aiks/canvas.cc
+++ b/engine/src/flutter/impeller/aiks/canvas.cc
@@ -193,18 +193,18 @@ void Canvas::DrawPaint(const Paint& paint) {
 bool Canvas::AttemptDrawBlurredRRect(const Rect& rect,
                                      Scalar corner_radius,
                                      const Paint& paint) {
-  Paint new_paint = paint;
-  if (new_paint.color_source.GetType() != ColorSource::Type::kColor ||
-      new_paint.style != Paint::Style::kFill) {
+  if (paint.color_source.GetType() != ColorSource::Type::kColor ||
+      paint.style != Paint::Style::kFill) {
     return false;
   }
 
-  if (!new_paint.mask_blur_descriptor.has_value() ||
-      new_paint.mask_blur_descriptor->style !=
-          FilterContents::BlurStyle::kNormal) {
+  if (!paint.mask_blur_descriptor.has_value() ||
+      paint.mask_blur_descriptor->style != FilterContents::BlurStyle::kNormal) {
     return false;
   }
 
+  Paint new_paint = paint;
+
   // For symmetrically mask blurred solid RRects, absorb the mask blur and use
   // a faster SDF approximation.