From f293435012a9a1d6b1314c94c800bb8f507cb876 Mon Sep 17 00:00:00 2001
From: Adam Barth <abarth@chromium.org>
Date: Thu, 6 Aug 2015 22:08:16 -0700
Subject: [PATCH] RenderViewport should use integer device pixels

When painting a scroll offset, RenderViewport should use integer device pixels
to prevent "shimmering" effects on images.

Fixes #486
---
 sky/packages/sky/lib/rendering/box.dart | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/sky/packages/sky/lib/rendering/box.dart b/sky/packages/sky/lib/rendering/box.dart
index d9925018919..e67c4d83f6c 100644
--- a/sky/packages/sky/lib/rendering/box.dart
+++ b/sky/packages/sky/lib/rendering/box.dart
@@ -1238,15 +1238,24 @@ class RenderViewport extends RenderBox with RenderObjectWithChildMixin<RenderBox
     }
   }
 
+  Offset get _scrollOffsetRoundedToIntegerDevicePixels {
+    double devicePixelRatio = sky.view.devicePixelRatio;
+    int dxInDevicePixels = (scrollOffset.dx * devicePixelRatio).round();
+    int dyInDevicePixels = (scrollOffset.dy * devicePixelRatio).round();
+    return new Offset(dxInDevicePixels / devicePixelRatio,
+                      dyInDevicePixels / devicePixelRatio);
+  }
+
   void paint(PaintingCanvas canvas, Offset offset) {
     if (child != null) {
+      Offset roundedScrollOffset = _scrollOffsetRoundedToIntegerDevicePixels;
       bool _needsClip = offset < Offset.zero ||
-                        !(offset & size).contains(((offset - scrollOffset) & child.size).bottomRight);
+                        !(offset & size).contains(((offset - roundedScrollOffset) & child.size).bottomRight);
       if (_needsClip) {
         canvas.save();
         canvas.clipRect(offset & size);
       }
-      canvas.paintChild(child, (offset - scrollOffset).toPoint());
+      canvas.paintChild(child, (offset - roundedScrollOffset).toPoint());
       if (_needsClip)
         canvas.restore();
     }
@@ -1256,7 +1265,7 @@ class RenderViewport extends RenderBox with RenderObjectWithChildMixin<RenderBox
     if (child != null) {
       assert(child.parentData is BoxParentData);
       Rect childBounds = child.parentData.position & child.size;
-      Point transformedPosition = position + scrollOffset;
+      Point transformedPosition = position + _scrollOffsetRoundedToIntegerDevicePixels;
       if (childBounds.contains(transformedPosition))
         child.hitTest(result, position: transformedPosition);
     }