From 2cd4dbcbf43023faded21c3fa15ab4a1075eb7d7 Mon Sep 17 00:00:00 2001 From: Matt Boetger Date: Thu, 21 Aug 2025 14:45:29 -0700 Subject: [PATCH] update viewport metrics in ios and add todos --- .../shell/platform/android/platform_view_android_jni_impl.cc | 1 + .../darwin/ios/framework/Source/FlutterViewController.mm | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/engine/src/flutter/shell/platform/android/platform_view_android_jni_impl.cc b/engine/src/flutter/shell/platform/android/platform_view_android_jni_impl.cc index 543373517b5..b915ad66f27 100644 --- a/engine/src/flutter/shell/platform/android/platform_view_android_jni_impl.cc +++ b/engine/src/flutter/shell/platform/android/platform_view_android_jni_impl.cc @@ -367,6 +367,7 @@ static void SetViewportMetrics(JNIEnv* env, env->GetIntArrayRegion(javaDisplayFeaturesState, 0, stateSize, &displayFeaturesState[0]); + // TODO(boetger): update for https://github.com/flutter/flutter/issues/149033 const flutter::ViewportMetrics metrics{ static_cast(devicePixelRatio), static_cast(physicalWidth), diff --git a/engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterViewController.mm b/engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterViewController.mm index 1e5aa0a4489..f7fd6cd518d 100644 --- a/engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterViewController.mm +++ b/engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterViewController.mm @@ -1478,6 +1478,11 @@ static flutter::PointerData::DeviceKind DeviceKindFromTouchType(UITouch* touch) CGFloat scale = screen.scale; _viewportMetrics.physical_width = self.view.bounds.size.width * scale; _viewportMetrics.physical_height = self.view.bounds.size.height * scale; + // TODO(louisehsu): update for https://github.com/flutter/flutter/issues/169147 + _viewportMetrics.physical_min_width_constraint = _viewportMetrics.physical_width; + _viewportMetrics.physical_max_width_constraint = _viewportMetrics.physical_width; + _viewportMetrics.physical_min_height_constraint = _viewportMetrics.physical_height; + _viewportMetrics.physical_max_height_constraint = _viewportMetrics.physical_height; } // Set _viewportMetrics physical paddings.