From 2c9ddfc8ffa40da6dbb82dc68ee50c1ec6b914ed Mon Sep 17 00:00:00 2001 From: Eric Seidel Date: Wed, 15 Apr 2015 13:29:47 -0700 Subject: [PATCH] Fix typo in sky_tool causing crash This will require me to roll the sky pub package, sigh. R=ianh@google.com Review URL: https://codereview.chromium.org/1090713002 --- sdk/packages/sky/lib/sky_tool | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sdk/packages/sky/lib/sky_tool b/sdk/packages/sky/lib/sky_tool index f7b8b6f1164..d245deac858 100755 --- a/sdk/packages/sky/lib/sky_tool +++ b/sdk/packages/sky/lib/sky_tool @@ -211,7 +211,7 @@ class StopSky(object): class SkyShellRunner(object): def _check_for_adb(self): try: - subprocess.call([ADB_PATH, '--help']) + subprocess.check_output([ADB_PATH, 'devices']) except OSError: print "'adb' (from the Android SDK) not in $PATH, can't continue." return False @@ -220,7 +220,7 @@ class SkyShellRunner(object): def main(self): logging.basicConfig(level=logging.WARNING) - if not self._check_for_adb() + if not self._check_for_adb(): sys.exit(2) parser = argparse.ArgumentParser(description='Sky Demo Runner')