From 2c4ff91e3cfe9cccd75111f813fbb9f9a5df4943 Mon Sep 17 00:00:00 2001 From: Damian Wrobel Date: Tue, 15 Sep 2020 17:05:12 +0200 Subject: [PATCH] Add missing header for (strcmp, strrchr) (flutter/engine#21176) Fixes the following compilation errors: ../../flutter/shell/platform/linux/fl_platform_plugin.cc:89:7: error: use of undeclared identifier 'strcmp' if (strcmp(format, kTextPlainFormat) != 0) { ^ ../../flutter/shell/platform/linux/fl_platform_plugin.cc:127:7: error: use of undeclared identifier 'strcmp' if (strcmp(method, kSetClipboardDataMethod) == 0) ^ ../../flutter/shell/platform/linux/fl_platform_plugin.cc:129:12: error: use of undeclared identifier 'strcmp' else if (strcmp(method, kGetClipboardDataMethod) == 0) ^ ../../flutter/shell/platform/linux/fl_platform_plugin.cc:131:12: error: use of undeclared identifier 'strcmp' else if (strcmp(method, kSystemNavigatorPopMethod) == 0) ^ ../../flutter/shell/platform/linux/fl_view.cc:194:7: error: use of undeclared identifier 'strcmp' if (strcmp(pspec->name, "scale-factor") == 0) { ^ ../../flutter/shell/platform/linux/fl_engine.cc:67:18: error: use of undeclared identifier 'strrchr' gchar* match = strrchr(l, '@'); ^ ../../flutter/shell/platform/linux/fl_engine.cc:75:11: error: use of undeclared identifier 'strrchr' match = strrchr(l, '.'); ^ ../../flutter/shell/platform/linux/fl_engine.cc:83:11: error: use of undeclared identifier 'strrchr' match = strrchr(l, '_'); ^ Signed-off-by: Damian Wrobel --- engine/src/flutter/shell/platform/linux/fl_engine.cc | 1 + .../src/flutter/shell/platform/linux/fl_mouse_cursor_plugin.cc | 1 + engine/src/flutter/shell/platform/linux/fl_platform_plugin.cc | 1 + engine/src/flutter/shell/platform/linux/fl_view.cc | 1 + 4 files changed, 4 insertions(+) diff --git a/engine/src/flutter/shell/platform/linux/fl_engine.cc b/engine/src/flutter/shell/platform/linux/fl_engine.cc index eb952a30a52..466aad53eb2 100644 --- a/engine/src/flutter/shell/platform/linux/fl_engine.cc +++ b/engine/src/flutter/shell/platform/linux/fl_engine.cc @@ -12,6 +12,7 @@ #include "flutter/shell/platform/linux/public/flutter_linux/fl_plugin_registry.h" #include +#include static constexpr int kMicrosecondsPerNanosecond = 1000; diff --git a/engine/src/flutter/shell/platform/linux/fl_mouse_cursor_plugin.cc b/engine/src/flutter/shell/platform/linux/fl_mouse_cursor_plugin.cc index 3da6e7a8f76..f00ea52d91b 100644 --- a/engine/src/flutter/shell/platform/linux/fl_mouse_cursor_plugin.cc +++ b/engine/src/flutter/shell/platform/linux/fl_mouse_cursor_plugin.cc @@ -5,6 +5,7 @@ #include "flutter/shell/platform/linux/fl_mouse_cursor_plugin.h" #include +#include #include "flutter/shell/platform/linux/public/flutter_linux/fl_method_channel.h" #include "flutter/shell/platform/linux/public/flutter_linux/fl_standard_method_codec.h" diff --git a/engine/src/flutter/shell/platform/linux/fl_platform_plugin.cc b/engine/src/flutter/shell/platform/linux/fl_platform_plugin.cc index d98e2b3792b..55aa6b00254 100644 --- a/engine/src/flutter/shell/platform/linux/fl_platform_plugin.cc +++ b/engine/src/flutter/shell/platform/linux/fl_platform_plugin.cc @@ -5,6 +5,7 @@ #include "flutter/shell/platform/linux/fl_platform_plugin.h" #include +#include #include "flutter/shell/platform/linux/public/flutter_linux/fl_json_method_codec.h" #include "flutter/shell/platform/linux/public/flutter_linux/fl_method_channel.h" diff --git a/engine/src/flutter/shell/platform/linux/fl_view.cc b/engine/src/flutter/shell/platform/linux/fl_view.cc index c6107bbe0a7..7405e38d45b 100644 --- a/engine/src/flutter/shell/platform/linux/fl_view.cc +++ b/engine/src/flutter/shell/platform/linux/fl_view.cc @@ -5,6 +5,7 @@ #include "flutter/shell/platform/linux/public/flutter_linux/fl_view.h" #include +#include #include "flutter/shell/platform/linux/fl_engine_private.h" #include "flutter/shell/platform/linux/fl_key_event_plugin.h"