From 2a6fa69bc2548b0402228e789201f9b30cf0e34b Mon Sep 17 00:00:00 2001
From: gaaclarke <30870216+gaaclarke@users.noreply.github.com>
Date: Fri, 17 Mar 2023 11:07:51 -0700
Subject: [PATCH] disabled the impeller unit tests again (flutter/engine#40389)

---
 engine/src/flutter/testing/run_tests.py | 38 ++++++++++++-------------
 1 file changed, 19 insertions(+), 19 deletions(-)

diff --git a/engine/src/flutter/testing/run_tests.py b/engine/src/flutter/testing/run_tests.py
index 98af7554990..9961cd1e53f 100755
--- a/engine/src/flutter/testing/run_tests.py
+++ b/engine/src/flutter/testing/run_tests.py
@@ -445,25 +445,25 @@ def run_cc_tests(build_dir, executable_filter, coverage, capture_core_dump):
     # TODO(117122): Re-enable impeller_unittests after shader compiler errors
     #               are addressed.
     # Impeller tests are only supported on macOS for now.
-    run_engine_executable(
-        build_dir,
-        'impeller_unittests',
-        executable_filter,
-        shuffle_flags,
-        coverage=coverage,
-        extra_env={
-            # pylint: disable=line-too-long
-            # See https://developer.apple.com/documentation/metal/diagnosing_metal_programming_issues_early?language=objc
-            'MTL_SHADER_VALIDATION':
-                '1',  # Enables all shader validation tests.
-            'MTL_SHADER_VALIDATION_GLOBAL_MEMORY':
-                '1',  # Validates accesses to device and constant memory.
-            'MTL_SHADER_VALIDATION_THREADGROUP_MEMORY':
-                '1',  # Validates accesses to threadgroup memory.
-            'MTL_SHADER_VALIDATION_TEXTURE_USAGE':
-                '1',  # Validates that texture references are not nil.
-        }
-    )
+    # run_engine_executable(
+    #     build_dir,
+    #     'impeller_unittests',
+    #     executable_filter,
+    #     shuffle_flags,
+    #     coverage=coverage,
+    #     extra_env={
+    #         # pylint: disable=line-too-long
+    #         # See https://developer.apple.com/documentation/metal/diagnosing_metal_programming_issues_early?language=objc
+    #         'MTL_SHADER_VALIDATION':
+    #             '1',  # Enables all shader validation tests.
+    #         'MTL_SHADER_VALIDATION_GLOBAL_MEMORY':
+    #             '1',  # Validates accesses to device and constant memory.
+    #         'MTL_SHADER_VALIDATION_THREADGROUP_MEMORY':
+    #             '1',  # Validates accesses to threadgroup memory.
+    #         'MTL_SHADER_VALIDATION_TEXTURE_USAGE':
+    #             '1',  # Validates that texture references are not nil.
+    #     }
+    # )
 
 
 def parse_impeller_vulkan_filter():