From 29740b2b62eaa5bf48a340718c19ade6716616c2 Mon Sep 17 00:00:00 2001 From: Brandon DeRosier Date: Tue, 5 Mar 2024 13:23:00 -0800 Subject: [PATCH] [Impeller] Enable depth buffer clipping & Stencil-then-Cover path rendering. (flutter/engine#51209) Turn the page, wash your hands. Addresses the following issues: * https://github.com/flutter/flutter/issues/143077 * https://github.com/flutter/flutter/issues/137714 * https://github.com/flutter/flutter/issues/138460 * https://github.com/flutter/flutter/issues/123671 * https://github.com/flutter/flutter/issues/141961 * https://github.com/flutter/flutter/issues/134432 Previous attempt: - https://github.com/flutter/engine/pull/50856 - reverted with https://github.com/flutter/engine/pull/51191 - fixed with https://github.com/flutter/engine/pull/51198 --- engine/src/flutter/impeller/entity/contents/content_context.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/engine/src/flutter/impeller/entity/contents/content_context.h b/engine/src/flutter/impeller/entity/contents/content_context.h index 6d4fc902986..d38df9ae03b 100644 --- a/engine/src/flutter/impeller/entity/contents/content_context.h +++ b/engine/src/flutter/impeller/entity/contents/content_context.h @@ -408,7 +408,7 @@ class ContentContext { /// // TODO(bdero): Remove this setting once StC is fully de-risked // https://github.com/flutter/flutter/issues/123671 - static constexpr bool kEnableStencilThenCover = false; + static constexpr bool kEnableStencilThenCover = true; #if IMPELLER_ENABLE_3D std::shared_ptr GetSceneContext() const;