diff --git a/dev/devicelab/lib/framework/dependency_smoke_test_task_definition.dart b/dev/devicelab/lib/framework/dependency_smoke_test_task_definition.dart index b20fddb41b3..d333046fffe 100644 --- a/dev/devicelab/lib/framework/dependency_smoke_test_task_definition.dart +++ b/dev/devicelab/lib/framework/dependency_smoke_test_task_definition.dart @@ -144,13 +144,6 @@ Future buildFlutterApkWithSpecifiedDependencyVersions({ .replaceFirst(kgpReplacementString, versions.kotlinVersion); await gradleSettingsFile.writeAsString(settingsContent, flush: true); - section('Add a dependency on a plugin'); - await flutter( - 'pub', - options: ['add', 'shared_preferences_android:2.4.9'], // Chosen randomly. - workingDirectory: appPath, - ); - // Ensure that gradle files exists from templates. section( "Ensure 'flutter build apk' succeeds with Gradle ${versions.gradleVersion}, AGP ${versions.agpVersion}, and Kotlin ${versions.kotlinVersion}", diff --git a/packages/flutter_tools/gradle/src/main/kotlin/FlutterPluginUtils.kt b/packages/flutter_tools/gradle/src/main/kotlin/FlutterPluginUtils.kt index e6ec439ba6d..2b622591eb8 100644 --- a/packages/flutter_tools/gradle/src/main/kotlin/FlutterPluginUtils.kt +++ b/packages/flutter_tools/gradle/src/main/kotlin/FlutterPluginUtils.kt @@ -517,16 +517,8 @@ object FlutterPluginUtils { getCompileSdkFromProject(project).toIntOrNull() ?: Int.MAX_VALUE var maxPluginCompileSdkVersion = projectCompileSdkVersion - // TODO(gmackall): This should be updated to reflect newer templates. - // The default for AGP 4.1.0 used in old templates. - val ndkVersionIfUnspecified = "21.1.6352462" - - // TODO(gmackall): We can remove this elvis when our minimum AGP is >= 8.2. - // This value (ndkVersion) is nullable on AGP versions below that. - // See https://developer.android.com/reference/tools/gradle-api/8.1/com/android/build/api/dsl/CommonExtension#ndkVersion(). - @Suppress("USELESS_ELVIS") - val projectNdkVersion: String = - getAndroidExtension(project).ndkVersion // ?: ndkVersionIfUnspecified + val projectNdkVersion = + getAndroidExtension(project).ndkVersion var maxPluginNdkVersion = projectNdkVersion var numProcessedPlugins = pluginList.size val pluginsWithHigherSdkVersion = mutableListOf() @@ -551,13 +543,8 @@ object FlutterPluginUtils { ) ) } - - // TODO(gmackall): We can remove this elvis when our minimum AGP is >= 8.2. - // This value (ndkVersion) is nullable on AGP versions below that. - // See https://developer.android.com/reference/tools/gradle-api/8.1/com/android/build/api/dsl/CommonExtension#ndkVersion(). - @Suppress("USELESS_ELVIS") val pluginNdkVersion: String = - getAndroidExtension(pluginProject).ndkVersion // ?: ndkVersionIfUnspecified + getAndroidExtension(pluginProject).ndkVersion maxPluginNdkVersion = VersionUtils.mostRecentSemanticVersion( pluginNdkVersion,