DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove buggy test to check if tasks can be posted on all native threads recursively from the emebdder. (flutter/engine#16214)

Browse Source 
This was never thread safe to shutdown of the concurrent message loop.
This commit is contained in:
Chinmay Garde 2020-01-29 18:16:09 -08:00 committed by GitHub
parent bc9735b1ac
commit 275ecda4d6
1 changed files with 0 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
engine/src/flutter/shell/platform/embedder/tests/embedder_unittests.cc
View File

@ -4006,40 +4006,5 @@ TEST_F(EmbedderTest, CanPostTaskToAllNativeThreads) {
ASSERT_FALSE(engine.is_valid());
}
TEST_F(EmbedderTest, CanPostTaskToAllNativeThreadsRecursively) {
EmbedderConfigBuilder builder(GetEmbedderContext());
builder.SetSoftwareRendererConfig();
static std::mutex engine_mutex;
static UniqueEngine engine;
static fml::AutoResetWaitableEvent event;
std::unique_lock engine_lock(engine_mutex);
engine.reset();
engine = builder.LaunchEngine();
ASSERT_TRUE(engine.is_valid());
ASSERT_EQ(FlutterEnginePostCallbackOnAllNativeThreads(
engine.get(),
[](FlutterNativeThreadType type, void* baton) {
// This should deadlock if the task mutex acquisition is
// busted.
std::scoped_lock engine_lock_inner(engine_mutex);
if (engine.is_valid()) {
ASSERT_EQ(FlutterEnginePostCallbackOnAllNativeThreads(
engine.get(),
[](FlutterNativeThreadType type,
void* baton) { event.Signal(); },
nullptr),
kSuccess);
}
},
&engine),
kSuccess);
engine_lock.unlock();
event.Wait();
engine.reset();
}
} // namespace testing
} // namespace flutter