DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Factor destination alpha into color blend output (flutter/engine#36338)

Browse Source
This commit is contained in:
Brandon DeRosier 2022-09-22 00:19:37 -07:00 committed by GitHub
parent 4cf02644fa
commit 2682bdb322
4 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
engine/src/flutter/impeller/entity/entity.cc
View File

@ -16,9 +16,6 @@
namespace impeller {
const BlendMode Entity::kLastPipelineBlendMode = BlendMode::kModulate;
const BlendMode Entity::kLastAdvancedBlendMode = BlendMode::kLuminosity;
Entity::Entity() = default;
Entity::~Entity() = default;

4
engine/src/flutter/impeller/entity/entity.h
View File

@ -19,8 +19,8 @@ class RenderPass;
class Entity {
public:
static const BlendMode kLastPipelineBlendMode;
static const BlendMode kLastAdvancedBlendMode;
static constexpr BlendMode kLastPipelineBlendMode = BlendMode::kModulate;
static constexpr BlendMode kLastAdvancedBlendMode = BlendMode::kLuminosity;
/// An enum to define how to repeat, fold, or omit colors outside of the
/// typically defined range of the source of the colors (such as the

1
engine/src/flutter/impeller/entity/entity_unittests.cc
View File

@ -662,6 +662,7 @@ TEST_P(EntityTest, BlendingModeOptions) {
static_assert(b == BlendMode::kClear); // Ensure the first item in
// the switch is the first
// item in the enum.
static_assert(Entity::kLastPipelineBlendMode == BlendMode::kModulate);
switch (b) {
case BlendMode::kClear:
blend_mode_names.push_back("Clear");

2
engine/src/flutter/impeller/entity/shaders/blending/advanced_blend.glsl
View File

@ -40,5 +40,5 @@ void main() {
vec3 blended = Blend(dst.rgb, src.rgb);
frag_color = vec4(blended * src.a, src.a);
frag_color = vec4(blended, 1) * src.a * dst.a;
}