From 1e86cd92e248ec99ea59b44ba3dd422b60f7bf0a Mon Sep 17 00:00:00 2001 From: Kaushik Iska Date: Wed, 7 Jul 2021 11:51:02 -0400 Subject: [PATCH] Make rasterFinishWallTime required (flutter/engine#27142) --- engine/src/flutter/lib/ui/platform_dispatcher.dart | 4 ++-- engine/src/flutter/lib/web_ui/lib/src/engine/profiler.dart | 1 + .../flutter/lib/web_ui/lib/src/ui/platform_dispatcher.dart | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/engine/src/flutter/lib/ui/platform_dispatcher.dart b/engine/src/flutter/lib/ui/platform_dispatcher.dart index c42b6336c8c..40814c93a24 100644 --- a/engine/src/flutter/lib/ui/platform_dispatcher.dart +++ b/engine/src/flutter/lib/ui/platform_dispatcher.dart @@ -1182,7 +1182,7 @@ class FrameTiming { required int buildFinish, required int rasterStart, required int rasterFinish, - int rasterFinishWallTime = -1, + required int rasterFinishWallTime, int frameNumber = -1, }) { return FrameTiming._([ @@ -1191,7 +1191,7 @@ class FrameTiming { buildFinish, rasterStart, rasterFinish, - if (rasterFinishWallTime == -1) rasterFinish else rasterFinishWallTime, + rasterFinishWallTime, frameNumber, ]); } diff --git a/engine/src/flutter/lib/web_ui/lib/src/engine/profiler.dart b/engine/src/flutter/lib/web_ui/lib/src/engine/profiler.dart index d9091f178d4..879902f0462 100644 --- a/engine/src/flutter/lib/web_ui/lib/src/engine/profiler.dart +++ b/engine/src/flutter/lib/web_ui/lib/src/engine/profiler.dart @@ -198,6 +198,7 @@ void frameTimingsOnRasterFinish() { buildFinish: _buildFinishMicros, rasterStart: _rasterStartMicros, rasterFinish: _rasterFinishMicros, + rasterFinishWallTime: _rasterFinishMicros, )); _vsyncStartMicros = -1; _buildStartMicros = -1; diff --git a/engine/src/flutter/lib/web_ui/lib/src/ui/platform_dispatcher.dart b/engine/src/flutter/lib/web_ui/lib/src/ui/platform_dispatcher.dart index 4349858cc3f..b0db81b6ff4 100644 --- a/engine/src/flutter/lib/web_ui/lib/src/ui/platform_dispatcher.dart +++ b/engine/src/flutter/lib/web_ui/lib/src/ui/platform_dispatcher.dart @@ -210,7 +210,7 @@ class FrameTiming { required int buildFinish, required int rasterStart, required int rasterFinish, - int rasterFinishWallTime = -1, + required int rasterFinishWallTime, int frameNumber = 1, }) { return FrameTiming._([ @@ -219,7 +219,7 @@ class FrameTiming { buildFinish, rasterStart, rasterFinish, - if (rasterFinishWallTime == -1) rasterFinish else rasterFinishWallTime, + rasterFinishWallTime, frameNumber, ]); }