DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #719 from Hixie/analyzer

Browse Source 
Analyzer improvements
This commit is contained in:
Ian Hickson 2015-12-03 20:10:49 -08:00
commit 1d4693fc9f
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/flutter_tools/lib/src/commands/analyze.dart
View File

@ -256,9 +256,9 @@ class AnalyzeCommand extends FlutterCommand {
];
RegExp generalPattern = new RegExp(r'^\[(error|warning|hint|lint)\] (.+) \(([^(),]+), line ([0-9]+), col ([0-9]+)\)$');
RegExp ignorePattern = new RegExp(r'// analyzer says "([^"]+)"');
RegExp allowedIdentifiersPattern = new RegExp(r'_?([A-Z]|_+)\b');
RegExp constructorTearOffsPattern = new RegExp('.+#.+// analyzer doesn\'t like constructor tear-offs');
RegExp allowedIdentifiers = new RegExp(r'_?([A-Z]|_+)\b');
RegExp ignorePattern = new RegExp(r'// analyzer says "([^"]+)"');
List<String> errorLines = output.toString().split('\n');
for (String errorLine in errorLines) {
@ -272,12 +272,16 @@ class AnalyzeCommand extends FlutterCommand {
int colNumber = int.parse(groups[5]);
File source = new File(filename);
List<String> sourceLines = source.readAsLinesSync();
String sourceLine = sourceLines[lineNumber-1];
String sourceLine = (lineNumber < sourceLines.length) ? sourceLines[lineNumber-1] : '';
bool shouldIgnore = false;
if (filename.endsWith('.mojom.dart')) {
// autogenerated code - TODO(ianh): Fix the Dart mojom compiler
shouldIgnore = true;
} else if ((sourceLines[0] == '/**') && (' * DO NOT EDIT. This is code generated'.matchAsPrefix(sourceLines[1]) != null)) {
// autogenerated code - TODO(ianh): Fix the intl package resource generator
shouldIgnore = true;
} else if (level == 'lint' && errorMessage == 'Name non-constant identifiers using lowerCamelCase.') {
if (allowedIdentifiers.matchAsPrefix(sourceLine, colNumber-1) != null)
if (allowedIdentifiersPattern.matchAsPrefix(sourceLine, colNumber-1) != null)
shouldIgnore = true;
} else if (constructorTearOffsPattern.allMatches(sourceLine).isNotEmpty) {
shouldIgnore = true;