From 1c27a458a8d15ccc9ffbec5a3cfcd349a7ff5a49 Mon Sep 17 00:00:00 2001 From: Chris Bracken Date: Wed, 9 May 2018 12:31:36 -0700 Subject: [PATCH] Correct profile-mode AOT snapshot flags (#17435) Previously, in non-release (i.e. profile) AOT builds, we were setting --no-checked and --conditional_directives flags. --no-checked is the default, and we don't make use of conditional directives in Flutter. --- packages/flutter_tools/lib/src/base/build.dart | 6 ------ packages/flutter_tools/test/base/build_test.dart | 2 -- 2 files changed, 8 deletions(-) diff --git a/packages/flutter_tools/lib/src/base/build.dart b/packages/flutter_tools/lib/src/base/build.dart index 402699dd167..45c8c8d87fc 100644 --- a/packages/flutter_tools/lib/src/base/build.dart +++ b/packages/flutter_tools/lib/src/base/build.dart @@ -194,12 +194,6 @@ class AOTSnapshotter { '--strong', ]); } - if (buildMode != BuildMode.release) { - genSnapshotArgs.addAll([ - '--no-checked', - '--conditional_directives', - ]); - } if (extraGenSnapshotOptions != null && extraGenSnapshotOptions.isNotEmpty) { printTrace('Extra gen_snapshot options: $extraGenSnapshotOptions'); genSnapshotArgs.addAll(extraGenSnapshotOptions); diff --git a/packages/flutter_tools/test/base/build_test.dart b/packages/flutter_tools/test/base/build_test.dart index ea84410e751..a7bff2a8c9a 100644 --- a/packages/flutter_tools/test/base/build_test.dart +++ b/packages/flutter_tools/test/base/build_test.dart @@ -396,8 +396,6 @@ void main() { '--dependencies=${fs.path.join(outputPath, 'snapshot.d')}', '--reify-generic-functions', '--strong', - '--no-checked', - '--conditional_directives', '--snapshot_kind=app-aot-assembly', '--assembly=${fs.path.join(outputPath, 'snapshot_assembly.S')}', 'main.dill',