From 1bf574e4a62fec7db02df11eae120efae8c9093f Mon Sep 17 00:00:00 2001
From: Brandon DeRosier <bdero@google.com>
Date: Mon, 20 May 2024 14:57:22 -0700
Subject: [PATCH] [Impeller] Fix use-after-move in SwapchainVK.
 (flutter/engine#52933)

Fix lint encountered in https://github.com/flutter/engine/pull/52932.
---
 .../renderer/backend/vulkan/swapchain/ahb/ahb_swapchain_vk.cc   | 2 +-
 .../renderer/backend/vulkan/swapchain/ahb/ahb_swapchain_vk.h    | 2 +-
 .../impeller/renderer/backend/vulkan/swapchain/swapchain_vk.cc  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/engine/src/flutter/impeller/renderer/backend/vulkan/swapchain/ahb/ahb_swapchain_vk.cc b/engine/src/flutter/impeller/renderer/backend/vulkan/swapchain/ahb/ahb_swapchain_vk.cc
index ad805a0a8cd..ddfdece7989 100644
--- a/engine/src/flutter/impeller/renderer/backend/vulkan/swapchain/ahb/ahb_swapchain_vk.cc
+++ b/engine/src/flutter/impeller/renderer/backend/vulkan/swapchain/ahb/ahb_swapchain_vk.cc
@@ -19,7 +19,7 @@ bool AHBSwapchainVK::IsAvailableOnPlatform() {
 
 AHBSwapchainVK::AHBSwapchainVK(const std::shared_ptr<Context>& context,
                                ANativeWindow* window,
-                               vk::UniqueSurfaceKHR surface,
+                               const vk::UniqueSurfaceKHR& surface,
                                const ISize& size,
                                bool enable_msaa)
     : context_(context),
diff --git a/engine/src/flutter/impeller/renderer/backend/vulkan/swapchain/ahb/ahb_swapchain_vk.h b/engine/src/flutter/impeller/renderer/backend/vulkan/swapchain/ahb/ahb_swapchain_vk.h
index a3b330f71cf..ddbcd13a52c 100644
--- a/engine/src/flutter/impeller/renderer/backend/vulkan/swapchain/ahb/ahb_swapchain_vk.h
+++ b/engine/src/flutter/impeller/renderer/backend/vulkan/swapchain/ahb/ahb_swapchain_vk.h
@@ -57,7 +57,7 @@ class AHBSwapchainVK final : public SwapchainVK {
 
   explicit AHBSwapchainVK(const std::shared_ptr<Context>& context,
                           ANativeWindow* window,
-                          vk::UniqueSurfaceKHR surface,
+                          const vk::UniqueSurfaceKHR& surface,
                           const ISize& size,
                           bool enable_msaa);
 };
diff --git a/engine/src/flutter/impeller/renderer/backend/vulkan/swapchain/swapchain_vk.cc b/engine/src/flutter/impeller/renderer/backend/vulkan/swapchain/swapchain_vk.cc
index a2cb44509bb..ce1951de851 100644
--- a/engine/src/flutter/impeller/renderer/backend/vulkan/swapchain/swapchain_vk.cc
+++ b/engine/src/flutter/impeller/renderer/backend/vulkan/swapchain/swapchain_vk.cc
@@ -67,7 +67,7 @@ std::shared_ptr<SwapchainVK> SwapchainVK::Create(
       auto ahb_swapchain = std::shared_ptr<AHBSwapchainVK>(new AHBSwapchainVK(
           context,             //
           window.GetHandle(),  //
-          std::move(surface),  //
+          surface,             //
           window.GetSize(),    //
           enable_msaa          //
           ));