From 1b3b4ec88f34bbce97cff181ea45ef3991f5065b Mon Sep 17 00:00:00 2001 From: Nurhan Turgut Date: Fri, 8 May 2020 13:30:13 -0700 Subject: [PATCH] skip font loading tests for safari (#18232) --- lib/web_ui/test/text/font_loading_test.dart | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/lib/web_ui/test/text/font_loading_test.dart b/lib/web_ui/test/text/font_loading_test.dart index 3ec78a53aa8..5b34d9d9346 100644 --- a/lib/web_ui/test/text/font_loading_test.dart +++ b/lib/web_ui/test/text/font_loading_test.dart @@ -26,8 +26,10 @@ Future main() async { ui.loadFontFromList(Uint8List(0), fontFamily: 'test-font'), throwsA(TypeMatcher())); }, + // TODO(nurhan): https://github.com/flutter/flutter/issues/56702 // TODO(nurhan): https://github.com/flutter/flutter/issues/50770 - skip: browserEngine == BrowserEngine.edge); + skip: (browserEngine == BrowserEngine.edge || + browserEngine == BrowserEngine.webkit)); test('loads Blehm font from buffer', () async { expect(_containsFontFamily('Blehm'), false); @@ -40,8 +42,10 @@ Future main() async { expect(_containsFontFamily('Blehm'), true); }, + // TODO(nurhan): https://github.com/flutter/flutter/issues/56702 // TODO(nurhan): https://github.com/flutter/flutter/issues/50770 - skip: browserEngine == BrowserEngine.edge); + skip: (browserEngine == BrowserEngine.edge || + browserEngine == BrowserEngine.webkit)); test('loading font should clear measurement caches', () async { final ui.ParagraphStyle style = ui.ParagraphStyle(); @@ -66,8 +70,10 @@ Future main() async { expect(_containsFontFamily('Blehm'), true); expect(TextMeasurementService.rulerManager.rulers.length, 0); }, + // TODO(nurhan): https://github.com/flutter/flutter/issues/56702 // TODO(nurhan): https://github.com/flutter/flutter/issues/50770 - skip: browserEngine == BrowserEngine.edge); + skip: (browserEngine == BrowserEngine.edge || + browserEngine == BrowserEngine.webkit)); test('loading font should send font change message', () async { final ui.PlatformMessageCallback oldHandler = ui.window.onPlatformMessage; @@ -93,8 +99,10 @@ Future main() async { expect(actualName, 'flutter/system'); expect(message, '{"type":"fontsChange"}'); }, + // TODO(nurhan): https://github.com/flutter/flutter/issues/56702 // TODO(nurhan): https://github.com/flutter/flutter/issues/50770 - skip: browserEngine == BrowserEngine.edge); + skip: (browserEngine == BrowserEngine.edge || + browserEngine == BrowserEngine.webkit)); }); }