From 1a573cf3eb9da16ae1b8fb17c4ed3dea203f5912 Mon Sep 17 00:00:00 2001 From: Adam Barth Date: Mon, 9 Mar 2015 16:19:33 -0700 Subject: [PATCH] SkyShell DCHECKs on startup sometimes Sometimes we try to draw a 0x0 picture. We shouldn't bother trying to turn a 0x0 picture into actual pixels. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/984153004 --- engine/src/flutter/shell/gpu/rasterizer.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/engine/src/flutter/shell/gpu/rasterizer.cc b/engine/src/flutter/shell/gpu/rasterizer.cc index d841ea8a478..8fb6836aafc 100644 --- a/engine/src/flutter/shell/gpu/rasterizer.cc +++ b/engine/src/flutter/shell/gpu/rasterizer.cc @@ -44,9 +44,13 @@ void Rasterizer::Draw(skia::RefPtr picture) { if (!surface_) return; + gfx::Size size = GetSize(picture.get()); + if (size.IsEmpty()) + return; + EnsureGLContext(); CHECK(context_->MakeCurrent(surface_.get())); - EnsureGaneshSurface(GetSize(picture.get())); + EnsureGaneshSurface(size); SkCanvas* canvas = ganesh_surface_->canvas(); canvas->drawPicture(picture.get());