From 17b261d8f58281166be0526bcdff53b665b677a7 Mon Sep 17 00:00:00 2001 From: Jonah Williams Date: Fri, 1 Sep 2023 18:01:06 -0700 Subject: [PATCH] [Impeller] Better demonstrate blur and draw picture? (flutter/engine#45388) The current goldens are changing a lot, this should be stabler. though not sure if it looks quite right. --- engine/src/flutter/impeller/aiks/aiks_unittests.cc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/engine/src/flutter/impeller/aiks/aiks_unittests.cc b/engine/src/flutter/impeller/aiks/aiks_unittests.cc index 9788c09cd08..5245c43da3a 100644 --- a/engine/src/flutter/impeller/aiks/aiks_unittests.cc +++ b/engine/src/flutter/impeller/aiks/aiks_unittests.cc @@ -3127,7 +3127,8 @@ TEST_P(AiksTest, CanCanvasDrawPictureWithAdvancedBlend) { auto picture = subcanvas.EndRecordingAsPicture(); Canvas canvas; - canvas.Translate({200, 200}); + canvas.DrawPaint({.color = Color::Black()}); + canvas.DrawCircle(Point::MakeXY(150, 150), 25, {.color = Color::Red()}); canvas.DrawPicture(picture); ASSERT_TRUE(OpenPlaygroundHere(canvas.EndRecordingAsPicture())); @@ -3143,13 +3144,14 @@ TEST_P(AiksTest, CanCanvasDrawPictureWithBackdropFilter) { }); auto image = std::make_shared(CreateTextureForFixture("kalimba.jpg")); Paint paint; - paint.color = Color::Red(); + paint.color = Color::Red().WithAlpha(0.5); subcanvas.DrawImage(image, Point::MakeXY(100.0, 100.0), paint); auto picture = subcanvas.EndRecordingAsPicture(); Canvas canvas; - canvas.Translate({200, 200}); + canvas.DrawPaint({.color = Color::Black()}); + canvas.DrawCircle(Point::MakeXY(150, 150), 25, {.color = Color::Red()}); canvas.DrawPicture(picture); ASSERT_TRUE(OpenPlaygroundHere(canvas.EndRecordingAsPicture()));