From 1663ac9e0d7451e026b70ec5fb15133cb397fdfb Mon Sep 17 00:00:00 2001 From: Chinmay Garde Date: Wed, 23 Oct 2019 14:49:56 -0700 Subject: [PATCH] Add FlutterEngineRunsAOTCompiledDartCode to the embedder API. (#13319) For embedder code that is configured for both AOT and JIT mode Dart execution based on the Flutter engine being linked to, this runtime check may be used to appropriately configure the `FlutterProjectArgs`. In JIT mode execution, the kernel snapshots must be present in the Flutter assets directory specified in the `FlutterProjectArgs`. For AOT execution, the fields `vm_snapshot_data`, `vm_snapshot_instructions`, `isolate_snapshot_data` and `isolate_snapshot_instructions` (along with their size fields) must be specified in `FlutterProjectArgs`. --- shell/platform/embedder/embedder.cc | 4 ++++ shell/platform/embedder/embedder.h | 20 +++++++++++++++++++ .../embedder/tests/embedder_unittests.cc | 5 +++++ 3 files changed, 29 insertions(+) diff --git a/shell/platform/embedder/embedder.cc b/shell/platform/embedder/embedder.cc index 3f2a972669d..ecf27cd6586 100644 --- a/shell/platform/embedder/embedder.cc +++ b/shell/platform/embedder/embedder.cc @@ -1573,3 +1573,7 @@ FlutterEngineResult FlutterEngineUpdateLocales(FLUTTER_API_SYMBOL(FlutterEngine) "Could not send message to update locale of " "a running Flutter application."); } + +bool FlutterEngineRunsAOTCompiledDartCode(void) { + return flutter::DartVM::IsRunningPrecompiledCode(); +} diff --git a/shell/platform/embedder/embedder.h b/shell/platform/embedder/embedder.h index 0ffcbae6f73..aaa2440e539 100644 --- a/shell/platform/embedder/embedder.h +++ b/shell/platform/embedder/embedder.h @@ -1456,6 +1456,26 @@ FlutterEngineResult FlutterEngineUpdateLocales(FLUTTER_API_SYMBOL(FlutterEngine) const FlutterLocale** locales, size_t locales_count); +//------------------------------------------------------------------------------ +/// @brief Returns if the Flutter engine instance will run AOT compiled +/// Dart code. This call has no threading restrictions. +/// +/// For embedder code that is configured for both AOT and JIT mode +/// Dart execution based on the Flutter engine being linked to, this +/// runtime check may be used to appropriately configure the +/// `FlutterProjectArgs`. In JIT mode execution, the kernel +/// snapshots must be present in the Flutter assets directory +/// specified in the `FlutterProjectArgs`. For AOT execution, the +/// fields `vm_snapshot_data`, `vm_snapshot_instructions`, +/// `isolate_snapshot_data` and `isolate_snapshot_instructions` +/// (along with their size fields) must be specified in +/// `FlutterProjectArgs`. +/// +/// @return True, if AOT Dart code is run. JIT otherwise. +/// +FLUTTER_EXPORT +bool FlutterEngineRunsAOTCompiledDartCode(void); + #if defined(__cplusplus) } // extern "C" #endif diff --git a/shell/platform/embedder/tests/embedder_unittests.cc b/shell/platform/embedder/tests/embedder_unittests.cc index dc38064b270..3ebb64479e8 100644 --- a/shell/platform/embedder/tests/embedder_unittests.cc +++ b/shell/platform/embedder/tests/embedder_unittests.cc @@ -2809,5 +2809,10 @@ TEST_F(EmbedderTest, CanUpdateLocales) { check_latch.Wait(); } +TEST_F(EmbedderTest, CanQueryDartAOTMode) { + ASSERT_EQ(FlutterEngineRunsAOTCompiledDartCode(), + flutter::DartVM::IsRunningPrecompiledCode()); +} + } // namespace testing } // namespace flutter