DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

fixes preceision error during SliverGridRegularTileLayout (#74851)

Browse Source
This commit is contained in:
chunhtai 2021-02-01 12:46:05 -08:00 committed by GitHub
parent 6bd54753d7
commit 13fe079bb3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 25 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter/lib/src/rendering/sliver_grid.dart
View File

@ -194,7 +194,7 @@ class SliverGridRegularTileLayout extends SliverGridLayout {
@override
int getMinChildIndexForScrollOffset(double scrollOffset) {
return mainAxisStride > 0.0 ? crossAxisCount * (scrollOffset ~/ mainAxisStride) : 0;
return mainAxisStride > precisionErrorTolerance ? crossAxisCount * (scrollOffset ~/ mainAxisStride) : 0;
}
@override

24
packages/flutter/test/widgets/grid_view_test.dart
View File

@ -315,6 +315,30 @@ void main() {
expect(find.text('4'), findsNothing);
});
testWidgets('SliverGridRegularTileLayout - can handle close to zero mainAxisStride', (WidgetTester tester) async {
const SliverGridDelegateWithMaxCrossAxisExtent delegate = SliverGridDelegateWithMaxCrossAxisExtent(
childAspectRatio: 1e300,
maxCrossAxisExtent: 500.0,
);
final SliverGridLayout layout = delegate.getLayout(
const SliverConstraints(
axisDirection: AxisDirection.down,
growthDirection: GrowthDirection.forward,
userScrollDirection: ScrollDirection.forward,
scrollOffset: 100.0,
precedingScrollExtent: 0.0,
overlap: 0.0,
remainingPaintExtent: 0.0,
crossAxisExtent: 500,
crossAxisDirection: AxisDirection.right,
viewportMainAxisExtent: 100.0,
remainingCacheExtent: 0.0,
cacheOrigin: 0.0,
)
);
expect(layout.getMinChildIndexForScrollOffset(1000.0), 0.0);
});
testWidgets('GridView - change maxChildCrossAxisExtent', (WidgetTester tester) async {
final List<int> log = <int>[];