DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Lots of trivial warning fixes

Browse Source 
Add type annotations in many places.
Fix some identifiers to have more lint-satisfying names.
Make all operator==s consistent in style.
Reorder some functions for consistency.
Make ParentData no longer dynamic, and fix all the code around that.
This commit is contained in:
Hixie 2015-10-09 13:54:40 -07:00
parent 61d33fa44c
commit 093f565475
1 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
engine/src/flutter/sky/tools/skyanalyzer
View File

@ -1,4 +1,5 @@
#!/usr/bin/env python
# -*- coding: utf-8 -*-
# Copyright 2014 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
@ -23,10 +24,19 @@ _IGNORED_PATTERNS = [
re.compile(r'^$'),
re.compile(r'^Analyzing \['),
re.compile(r'^No issues found'),
# Ignore analyzer status output.
re.compile(r'^[0-9]+ (error|warning|hint).*found[.]'),
# Disable the Strong checks that we don't care about.
re.compile(r'^\[error\] Invalid override\. The type of [^ ]+ \(.+\) is not a subtype of [^ ]+ \(.+\)\.'), # we allow type narrowing
re.compile(r'^\[(warning|hint)\] .+ will need runtime check to cast to type .+'), # https://github.com/dart-lang/sdk/issues/24542
re.compile(r'^\[hint\] .+ requires dynamic invoke'), # too many false positives, e.g. https://github.com/dart-lang/sdk/issues/24564
re.compile(r'^\[hint\] Runtime check on non-ground type .+ may throw StrongModeError'), # https://github.com/dart-lang/sdk/issues/24565
re.compile(r'^\[hint] \([_, ]+\) .+ has inferred type '), # ignore underscore-only arguments
# Disable the lint checks that will be caught by code review
re.compile(r'^\[lint\] Avoid defining a one-member abstract class when a simple function will do'),
re.compile(r'^\[lint\] Prefer using lowerCamelCase for constant names.'),
# TODO: Fix all the warnings in the mojo packages
re.compile(r'.*pub-cache.*\.mojom\.dart'),
@ -54,7 +64,14 @@ def main():
subprocess.check_output([
DARTANALYZER, "--package-warnings",
"--package-root", os.path.join(WORKBENCH, "packages"),
"--ignore-unrecognized-flags",
"--fatal-hints",
"--fatal-warnings",
"--lints",
"--strong",
"--strong-hints",
"--enable-strict-call-checks",
"--enable_type_checks",
"--supermixin",
] + app_paths, stderr=subprocess.STDOUT)
except subprocess.CalledProcessError as e: