DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-05 11:19:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

explicitly catch ArgumentError, and add tests (#52757)

Browse Source
This commit is contained in:
Christopher Fujino 2020-03-17 12:55:57 -07:00 committed by GitHub
parent a4d30c1607
commit 071d4eb2c8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 34 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/flutter_tools/lib/src/base/process.dart
View File

@ -542,6 +542,9 @@ class _DefaultProcessUtils implements ProcessUtils {
} on Exception catch (error) {
_logger.printTrace('$cli failed with $error');
return false;
} on ArgumentError catch (error) {
_logger.printTrace('$cli failed with $error');
return false;
}
}
@ -556,6 +559,9 @@ class _DefaultProcessUtils implements ProcessUtils {
} on Exception catch (error) {
_logger.printTrace('$cli failed with $error');
return false;
} on ArgumentError catch (error) {
_logger.printTrace('$cli failed with $error');
return false;
}
}

28
packages/flutter_tools/test/general.shard/base/process_test.dart
View File

@ -360,6 +360,20 @@ void main() {
);
expect(processUtils.exitsHappySync(<String>['boohoo']), isFalse);
});
testWithoutContext('catches Exception and returns false', () {
when(mockProcessManager.runSync(<String>['boohoo'])).thenThrow(
const ProcessException('Process failed', <String>[]),
);
expect(processUtils.exitsHappySync(<String>['boohoo']), isFalse);
});
testWithoutContext('catches ArgumentError and returns false', () {
when(mockProcessManager.runSync(<String>['nonesuch'])).thenThrow(
ArgumentError('Invalid argument(s): Cannot find executable for nonesuch')
);
expect(processUtils.exitsHappySync(<String>['nonesuch']), isFalse);
});
});
group('exitsHappy', () {
@ -387,6 +401,20 @@ void main() {
});
expect(await processUtils.exitsHappy(<String>['boohoo']), isFalse);
});
testWithoutContext('catches Exception and returns false', () async {
when(mockProcessManager.run(<String>['boohoo'])).thenThrow(
const ProcessException('Process failed', <String>[]),
);
expect(await processUtils.exitsHappy(<String>['boohoo']), isFalse);
});
testWithoutContext('catches ArgumentError and returns false', () async {
when(mockProcessManager.run(<String>['nonesuch'])).thenThrow(
ArgumentError('Invalid argument(s): Cannot find executable for nonesuch'),
);
expect(await processUtils.exitsHappy(<String>['nonesuch']), isFalse);
});
});
}