From 06e24a71ba819e9cfbcef7e3265458c5486f8a89 Mon Sep 17 00:00:00 2001 From: stuartmorgan Date: Tue, 7 Apr 2020 13:19:49 -0700 Subject: [PATCH] Fix flutter_windows_unittests runtime dependency (flutter/engine#17524) The transitive dependency on the embedder library brings in the right runtime for the build mode, so directly depending on the JIT version isn't necessary, and causes duplicate symbol issues in release builds. --- engine/src/flutter/shell/platform/windows/BUILD.gn | 5 ----- 1 file changed, 5 deletions(-) diff --git a/engine/src/flutter/shell/platform/windows/BUILD.gn b/engine/src/flutter/shell/platform/windows/BUILD.gn index 88869ace762..5de1a712a48 100644 --- a/engine/src/flutter/shell/platform/windows/BUILD.gn +++ b/engine/src/flutter/shell/platform/windows/BUILD.gn @@ -123,11 +123,6 @@ executable("flutter_windows_unittests") { ":flutter_windows_headers", ":flutter_windows_source", "//flutter/testing", - - # TODO(chunhtai): Consider refactoring flutter_root/testing so that there's a testing - # target that doesn't require a Dart runtime to be linked in. - # https://github.com/flutter/flutter/issues/41414. - "//third_party/dart/runtime:libdart_jit", "//third_party/rapidjson", ] }