From 06addee8ac4c19ea0f11a87eba91f581f756cf13 Mon Sep 17 00:00:00 2001 From: ColdPaleLight <31977171+ColdPaleLight@users.noreply.github.com> Date: Wed, 12 Jan 2022 02:25:10 +0800 Subject: [PATCH] Remove unused setPersistentIsolateData function (flutter/engine#30795) --- .../framework/Source/FlutterDartProject.mm | 20 ------------------- .../Source/FlutterDartProject_Internal.h | 13 ------------ 2 files changed, 33 deletions(-) diff --git a/engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterDartProject.mm b/engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterDartProject.mm index c4c9ced24ac..27700f81455 100644 --- a/engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterDartProject.mm +++ b/engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterDartProject.mm @@ -337,24 +337,4 @@ flutter::Settings FLTDefaultSettingsForBundle(NSBundle* bundle) { return @"io.flutter.flutter.app"; } -#pragma mark - Settings utilities - -- (void)setPersistentIsolateData:(NSData*)data { - if (data == nil) { - return; - } - - NSData* persistent_isolate_data = [data copy]; - fml::NonOwnedMapping::ReleaseProc data_release_proc = [persistent_isolate_data](auto, auto) { - [persistent_isolate_data release]; - }; - _settings.persistent_isolate_data = std::make_shared( - static_cast(persistent_isolate_data.bytes), // bytes - persistent_isolate_data.length, // byte length - data_release_proc // release proc - ); -} - -#pragma mark - PlatformData utilities - @end diff --git a/engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterDartProject_Internal.h b/engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterDartProject_Internal.h index 74203864f42..0cd2cc95f25 100644 --- a/engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterDartProject_Internal.h +++ b/engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterDartProject_Internal.h @@ -36,19 +36,6 @@ flutter::Settings FLTDefaultSettingsForBundle(NSBundle* bundle = nil); + (NSString*)domainNetworkPolicy:(NSDictionary*)appTransportSecurity; + (bool)allowsArbitraryLoads:(NSDictionary*)appTransportSecurity; -/** - * The embedder can specify data that the isolate can request synchronously on launch. Engines - * launched using this configuration can access the persistent isolate data via the - * `PlatformDispatcher.getPersistentIsolateData` accessor. - * - * @param data The persistent isolate data. This data is persistent for the duration of the Flutter - * application and is available even after isolate restarts. Because of this lifecycle, - * the size of this data must be kept to a minimum and platform channels used for - * communication that does not require synchronous embedder to isolate communication - * close to isolate launch. - **/ -- (void)setPersistentIsolateData:(NSData*)data; - @end NS_ASSUME_NONNULL_END