From 05d59ee4621458fc2e9d6ce227e1ae39bd101d3b Mon Sep 17 00:00:00 2001 From: Raph Levien Date: Thu, 26 Jun 2014 14:00:43 -0700 Subject: [PATCH] Disable "palt" OpenType feature Proper Japanese layout requires sophisticated rules for spacing punctuation, not just turning on the "palt" (proportional alternate) feature. Until we can support the whole set, roll back palt. Change-Id: If2359c529b70b1dd45dddc00e5f4aa1c91f8b0e9 --- engine/src/flutter/libs/minikin/Layout.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/engine/src/flutter/libs/minikin/Layout.cpp b/engine/src/flutter/libs/minikin/Layout.cpp index 48db129cf77..01b6599628f 100644 --- a/engine/src/flutter/libs/minikin/Layout.cpp +++ b/engine/src/flutter/libs/minikin/Layout.cpp @@ -621,7 +621,13 @@ void Layout::doLayoutWord(const uint16_t* buf, size_t start, size_t count, size_ static void addFeatures(vector* features) { // hardcoded features, to be repaced with more flexible configuration static hb_feature_t palt = { HB_TAG('p', 'a', 'l', 't'), 1, 0, ~0u }; + + // Don't enable "palt" for now, pending implementation of more of the + // W3C Japanese layout recommendations. See: + // http://www.w3.org/TR/2012/NOTE-jlreq-20120403/ +#if 0 features->push_back(palt); +#endif } void Layout::doLayoutRun(const uint16_t* buf, size_t start, size_t count, size_t bufSize,