DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Make tests/clipping/canvas-rounded-corners.sky actually run.

Browse Source 
Because we dump dart errors to LOG(ERROR) (stderr) instead
of console.log / stdout, tests with dart errors just "pass"
and we don't notice they're not running.

This was the case with canvas-rounded-corners.sky.

I don't think this test actually passes yet, despite it
claiming to, but I at least have made it run and not crash.

Required me commenting out a ton of CanvasRenderingContext2D, but
that's fine, it wasn't actually working and it's better to have
it be compiling valid dart.

R=abarth@chromium.org, ojan@chromium.org
BUG=

Review URL: https://codereview.chromium.org/936563002
This commit is contained in:
Eric Seidel 2015-02-17 12:25:15 -08:00
parent 64409f370b
commit 04cd457d91
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
engine/src/flutter/tests/clipping/canvas-rounded-corners.sky
View File

@ -16,11 +16,13 @@
</ul>
<canvas id="theCanvas" width="257" height="257"></canvas>
<script>
import 'dart:sky';
void main() {
var theCanvas = document.getElementById('theCanvas');
var context = theCanvas.getContext('2d');
context.fillColor = 'green';
context.fillRect(0, 0, theCanvas.width, theCanvas.width);
context.fillRect(0.0, 0.0, 1.0 * theCanvas.width, 1.0 * theCanvas.width);
}
</script>
</sky>