DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove ability to override mac_sdk_path in flutter/tools/gn (flutter/engine#11013)

Browse Source 
This was only required to use an older i386 enabled Mac SDK with a newer version of Xcode for gen_snapshot. This limitation has been patched already.
This commit is contained in:
Chinmay Garde 2019-08-15 16:33:12 -07:00 committed by GitHub
parent 6439e90520
commit 03d9c4f025
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
engine/src/flutter/tools/gn
View File

@ -259,11 +259,8 @@ def to_gn_args(args):
gn_args['full_dart_sdk'] = args.full_dart_sdk
if sys.platform == 'darwin':
gn_args['mac_sdk_path'] = args.mac_sdk_path
if args.build_glfw_shell:
gn_args['build_glfw_shell'] = True
if gn_args['mac_sdk_path'] == '':
gn_args['mac_sdk_path'] = os.getenv('FLUTTER_MAC_SDK_PATH', '')
return gn_args
@ -326,10 +323,6 @@ def parse_args(args):
help='include trained dart2js and dartdevc snapshots. Enable only on steps that create an SDK')
parser.add_argument('--no-full-dart-sdk', dest='full_dart_sdk', action='store_false')
parser.add_argument('--mac-sdk-path', default='', type=str,
help='On the mac, the SDK is inferred from the Xcode location unless this flag is specified. ' +
' Setting the FLUTTER_MAC_SDK_PATH environment variable achieves the same effect.')
parser.add_argument('--ide', default='', type=str,
help='The IDE files to generate using GN. Use `gn gen help` and look for the --ide flag to' +
' see supported IDEs. If this flag is not specified, a platform specific default is selected.')