From 0010be93cdfd5bb20aaf55ff98298dd1622f1219 Mon Sep 17 00:00:00 2001 From: Jason Simmons Date: Thu, 17 Nov 2022 13:50:04 -0800 Subject: [PATCH] Add semantics constants to the exported symbols list for the embedder library (flutter/engine#37526) Fixes https://github.com/flutter/flutter/issues/114657 --- .../src/flutter/shell/platform/embedder/embedder_exports.lst | 1 + engine/src/flutter/testing/symbols/verify_exported.dart | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/engine/src/flutter/shell/platform/embedder/embedder_exports.lst b/engine/src/flutter/shell/platform/embedder/embedder_exports.lst index 7a60814cd4c..ccaf84b2ea5 100644 --- a/engine/src/flutter/shell/platform/embedder/embedder_exports.lst +++ b/engine/src/flutter/shell/platform/embedder/embedder_exports.lst @@ -8,6 +8,7 @@ global: Flutter*; __Flutter*; + kFlutter*; kDartIsolateSnapshotData; kDartIsolateSnapshotInstructions; kDartVmSnapshotData; diff --git a/engine/src/flutter/testing/symbols/verify_exported.dart b/engine/src/flutter/testing/symbols/verify_exported.dart index 76095402c4c..2e97f3e7552 100644 --- a/engine/src/flutter/testing/symbols/verify_exported.dart +++ b/engine/src/flutter/testing/symbols/verify_exported.dart @@ -274,7 +274,8 @@ int _checkLinux(String outPath, String nmPath, Iterable builds) { break; } if (!(entry.name.startsWith('Flutter') - || entry.name.startsWith('__Flutter'))) { + || entry.name.startsWith('__Flutter') + || entry.name.startsWith('kFlutter'))) { print('ERROR: $libFlutter exports an unexpected symbol name: ($entry)'); print(' Library has $entries.'); failures++;